From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/10 v3] spl, nand: add 4bit HW ecc oob first nand_read_page function
Date: Tue, 11 Oct 2011 07:41:19 +0200 [thread overview]
Message-ID: <4E93D6FF.9020408@denx.de> (raw)
In-Reply-To: <4E9360E7.3030205@freescale.com>
Hello Scott,
Scott Wood wrote:
> On 10/06/2011 12:45 AM, Heiko Schocher wrote:
>> similiar to commit dc7cd8e59ba077f3b4c1a4557c9cd86a31b9ab1f, only
>> adapted for the new spl framework.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> Cc: Scott Wood <scottwood@freescale.com>
>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>> Cc: Sandeep Paulraj <s-paulraj@ti.com>
>>
>> ---
>> changes for v3:
>> - add comment from Scott Wood:
>> as BSS is cleared, no need for intializing vars with 0
>> remove this.
>>
>> drivers/mtd/nand/nand_spl_simple.c | 43 +++++++++++++++++++++++++++++++++++-
>> 1 files changed, 42 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/nand_spl_simple.c b/drivers/mtd/nand/nand_spl_simple.c
>> index 71491d4..622a9b5 100644
>> --- a/drivers/mtd/nand/nand_spl_simple.c
>> +++ b/drivers/mtd/nand/nand_spl_simple.c
>> @@ -140,6 +140,47 @@ static int nand_is_bad_block(int block)
>> return 0;
>> }
>>
>> +#if defined(CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST)
>
> Change the name to not be 4BIT-specific, and add documentation for this
> config option.
Hmm.. this is no new config option, it enables on davinci socs the
4Bit NAND HW ECC generation ... and I need this in spl code too ...
Ok, you are right, there is no documentation of this config option.
Should I add this documentation in this patch or in a seperate patch?
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-10-11 5:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 14:28 [U-Boot] [PATCH v2 05/10] spl, nand: add 4bit HW ecc oob first nand_read_page function Heiko Schocher
2011-10-05 21:45 ` Scott Wood
2011-10-06 5:41 ` Heiko Schocher
2011-10-06 5:45 ` [U-Boot] [PATCH 05/10 v3] " Heiko Schocher
2011-10-06 16:05 ` Tom Rini
2011-10-10 21:17 ` Scott Wood
2011-10-11 5:41 ` Heiko Schocher [this message]
2011-10-11 5:49 ` Wolfgang Denk
2011-10-25 15:24 ` Scott Wood
2011-10-26 6:16 ` Heiko Schocher
2011-10-26 16:58 ` Scott Wood
2011-10-27 5:23 ` Heiko Schocher
2011-10-27 18:14 ` Scott Wood
2011-10-28 6:05 ` Heiko Schocher
2011-10-28 16:03 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E93D6FF.9020408@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox