From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sven Schnelle Date: Wed, 12 Oct 2011 16:51:17 +0200 Subject: [U-Boot] [PATCH 1/2] AVR32: use generic mmc framework In-Reply-To: <4E95A464.5070208@gmail.com> References: <1318424949-24760-1-git-send-email-svens@stackframe.org> <1318424949-24760-2-git-send-email-svens@stackframe.org> <4E95A464.5070208@gmail.com> Message-ID: <4E95A965.20504@stackframe.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/12/2011 04:29 PM, Andreas Bie?mann wrote: > Dear Sven, > > Am 12.10.2011 15:09, schrieb Sven Schnelle: >> gen_atmel_mci works on AVR32 as well, so no need to use the legacy >> mmc driver. This also has the nice side effect of being able to use >> SDHC cards an AVR32 boards. >> >> Signed-off-by: Sven Schnelle > I have to NACK this patch cause it produces new compile warnings. > > $ PATH=$AVR32_PATH:$PATH BUILD_DIR=/tmp/build_uboot BUILD_NCPU=8 > ./MAKEALL atstk1002 > Configuring for atstk1002 board... > board.c: In function 'board_init_r': > board.c:338: warning: implicit declaration of function 'mmc_initialize' > atstk1000.c: In function 'board_mmc_init': > atstk1000.c:147: warning: implicit declaration of function 'atmel_mci_init' > text data bss dec hex filename > 106091 7504 211676 325271 4f697 /tmp/build_uboot/u-boot Oops. Should be easily fixable. > --------------------- SUMMARY ---------------------------- > Boards compiled: 1 > Boards with warnings or errors: 1 ( atstk1002 ) > ---------------------------------------------------------- > > And does not work on device: > > a) mmc init is not known? Is this not longer necessar 'mmc init' is only available if CONFIG_GENERIC_MMC isn't set, at least that's how i unterstand the source code. (See common/cmd_mmc.c:29) > b) ext2ls is not reliable: > > ---8<--- > U-Boot> ext2ls mmc 0:1 > 1024 . > 1024 .. > 12288 lost+found > gen_atmel_mci: CMDR 00051051 (17) ARGR 02008600 (SR: 00400025) Data > Transfer Failed > ** ext2fs_devread read error - last part > U-Boot> > --->8--- Hmm, that's really bad. What type of card is this? MMC, SD or SDHC? Regards Sven