From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] AVR32: switch to generic mmc framework
Date: Wed, 12 Oct 2011 19:01:52 +0200 [thread overview]
Message-ID: <4E95C800.4050107@emk-elektronik.de> (raw)
In-Reply-To: <1318424949-24760-1-git-send-email-svens@stackframe.org>
Dear Sven Schnelle,
> Hi List,
>
> these patches switch all AVR32 boards to the generic MMC framework. Motivation
> for doing so is to be able to boot from SDHC cards. The second patch removes
> the legacy atmel_mci driver, as it is no longer used by any board.
>
> I've only tried this code on the Atmel ATNGW100, as i have no other AVR32 boards.
> Would be great if some other users could try that patch on different platforms.
>
> It seems like the gen_atmel_mci driver doesn't work with Multible Block transfer on
> AVR32, but the old code didn't used that mode either. So that's something for the TODO
> list for future improvements.
1. your patch title is misleading, because it also affects the AT91 architecture.
use AVR32 when patches affect avr32 only
use AT91 when patches affect at91 only
use ATMEL when patches affect generic Atmel stuff
2. you should use the git rename feature to rename files
As I see it, all this should come as three patches:
1. switching *all* AVR32 and AT91 boards to use the *existing* generic driver
2. removal of the now obsolete legacy driver
3. renaming the existing generic driver into the old legacy name
(this is a pure cosmetic act)
I would tend to dispute whether 3. is really necessary and beneficial
Best Regards
Reinhard
next prev parent reply other threads:[~2011-10-12 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 13:09 [U-Boot] [PATCH] AVR32: switch to generic mmc framework Sven Schnelle
2011-10-12 13:09 ` [U-Boot] [PATCH 1/2] AVR32: use " Sven Schnelle
2011-10-12 14:29 ` Andreas Bießmann
2011-10-12 14:51 ` Sven Schnelle
2011-10-12 14:59 ` Andreas Bießmann
2011-10-12 15:08 ` Sven Schnelle
2011-10-12 15:18 ` Andreas Bießmann
2011-10-14 12:30 ` Andreas Bießmann
2011-10-13 7:52 ` Sven Schnelle
2011-10-12 17:54 ` Wolfgang Denk
2011-10-13 7:45 ` Sven Schnelle
2011-10-12 13:09 ` [U-Boot] [PATCH 2/2] AVR32: remove old atmel_mci driver Sven Schnelle
2011-10-12 17:01 ` Reinhard Meyer [this message]
2011-10-13 8:04 ` [U-Boot] [PATCH] AVR32: switch to generic mmc framework Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E95C800.4050107@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox