From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4] Remove duplicate functions for power and sleep configuration
Date: Thu, 13 Oct 2011 08:28:21 +0200 [thread overview]
Message-ID: <4E968505.5070909@denx.de> (raw)
In-Reply-To: <4E9675BC.4000504@denx.de>
Hello Christian,
Heiko Schocher wrote:
> Hello Christian,
>
> Christian Riesch wrote:
>> Hi,
>> these patches apply on top of Heiko Schocher's patches for the enbw_cmc
>> board. They remove the duplicate functions for the power and sleep
>> controller of the davinci devices.
>>
>> The first patch renames the low level configuration functions since they
>> can not only be used for the AM1808 but for the entire da850 family.
>>
>> The second patch corrects the mask for the state bitfield of the MDSTAT
>> registers. Similar patches have been already submitted for the Linux kernel
>> and other parts of u-boot, see e.g. http://patchwork.ozlabs.org/patch/114942/
>>
>> Patch number three adds a function to set an LPSC module to Sync Reset
>> state as this is required for DDR memory controller initialization.
>>
>> The forth patch finally replaces the PSC related functions in
>> arch/arm/cpu/arm926ejs/davinci/da850_lowlevel.c by those of psc.c.
>>
>> I tested the DDR initialization functions on my board and they worked fine,
>> but of course I can only compile-test them for Heiko's board.
>>
>> I am looking forward to your comments!
>
> just tried your patches, but after applying it, my console on UART2
> is not longer working properly on the enbw_cmc board, it seems, Tx
> only works ... investigating this behaviour ...
Found it, your code is Ok. If you sent an update version of this
patchset, with the issues fixed, I test them on my hardware, thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2011-10-13 6:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 11:31 [U-Boot] [PATCH 0/4] Remove duplicate functions for power and sleep configuration Christian Riesch
2011-10-12 11:31 ` [U-Boot] [PATCH 1/4] arm, davinci: Rename AM1808 lowlevel functions to DA850 Christian Riesch
2011-10-13 5:23 ` Heiko Schocher
2011-10-13 5:37 ` Christian Riesch
2011-10-12 11:31 ` [U-Boot] [PATCH 2/4] arm, davinci: Correct the MDSTAT.STATE mask Christian Riesch
2011-10-15 20:34 ` Sergei Shtylyov
2011-10-16 17:36 ` Christian Riesch
2011-10-12 11:31 ` [U-Boot] [PATCH 3/4] arm, davinci: Add function lpsc_syncreset() Christian Riesch
2011-10-13 5:42 ` Heiko Schocher
2011-10-13 6:14 ` Christian Riesch
2011-10-12 11:31 ` [U-Boot] [PATCH 4/4] arm, davinci: Remove the duplication of LPSC functions in da850_lowlevel.c Christian Riesch
2011-10-12 11:47 ` [U-Boot] [PATCH 0/4] Remove duplicate functions for power and sleep configuration Christian Riesch
2011-10-13 5:23 ` Heiko Schocher
2011-10-13 6:28 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E968505.5070909@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox