From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 13 Oct 2011 08:28:21 +0200 Subject: [U-Boot] [PATCH 0/4] Remove duplicate functions for power and sleep configuration In-Reply-To: <4E9675BC.4000504@denx.de> References: <1318419080-14396-1-git-send-email-christian.riesch@omicron.at> <4E9675BC.4000504@denx.de> Message-ID: <4E968505.5070909@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Christian, Heiko Schocher wrote: > Hello Christian, > > Christian Riesch wrote: >> Hi, >> these patches apply on top of Heiko Schocher's patches for the enbw_cmc >> board. They remove the duplicate functions for the power and sleep >> controller of the davinci devices. >> >> The first patch renames the low level configuration functions since they >> can not only be used for the AM1808 but for the entire da850 family. >> >> The second patch corrects the mask for the state bitfield of the MDSTAT >> registers. Similar patches have been already submitted for the Linux kernel >> and other parts of u-boot, see e.g. http://patchwork.ozlabs.org/patch/114942/ >> >> Patch number three adds a function to set an LPSC module to Sync Reset >> state as this is required for DDR memory controller initialization. >> >> The forth patch finally replaces the PSC related functions in >> arch/arm/cpu/arm926ejs/davinci/da850_lowlevel.c by those of psc.c. >> >> I tested the DDR initialization functions on my board and they worked fine, >> but of course I can only compile-test them for Heiko's board. >> >> I am looking forward to your comments! > > just tried your patches, but after applying it, my console on UART2 > is not longer working properly on the enbw_cmc board, it seems, Tx > only works ... investigating this behaviour ... Found it, your code is Ok. If you sent an update version of this patchset, with the issues fixed, I test them on my hardware, thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany