[U-Boot] [PATCH 09/17 RESEND V5] iMX28: Add GPMI NAND driver

Marek Vasut
2011-11-04T13:30:33Z

> Hi Marek,
>
> On 10/22/2011 01:44 AM, Marek Vasut wrote:
> > diff --git a/drivers/mtd/nand/mxs_nand.c b/drivers/mtd/nand/mxs_nand.c
> > new file mode 100644
> > index 0000000..ce2a326
> > --- /dev/null
> > +++ b/drivers/mtd/nand/mxs_nand.c
>
> <snip>
>
> > + nand->options |= NAND_NO_SUBPAGE_WRITE;
>
> I think we should change this a little bit. Unluckily I don't know what
> is the best way to fix it. As far as I have understood, the
> NAND_NO_SUBPAGE_WRITE is a chip option, not for a driver.
>
> At nand_base.c is
> chip->options &= ~NAND_CHIPOPTIONS_MSK;
> chip->options |= type->options & NAND_CHIPOPTIONS_MSK;
> so the bit is masked out anyway and subpages are enabled.
>
> After that UBI tries to read VID header at 512 by default. I had to use
> "ubi part root 2048" to override it. Besides of that driver seems to
> work fine.

Can you please supply me with the commands that trigger such bug and the
resulting problem you then see? So I can reproduce it and fix it? Thanks!
>
> --
> Veli-Pekka Peltola
> Bluegiga Technologies