From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilya Yanok <yanok@emcraft.com>
Date: Fri, 14 Oct 2011 02:18:47 +0400
Subject: [U-Boot] [PATCH 4/6] davinci_emac: fix for running with dcache
 enabled
In-Reply-To: <201110091156.47437.vapier@gentoo.org>
References: <1317857806-16549-1-git-send-email-yanok@emcraft.com>
	<201110071334.20378.vapier@gentoo.org>
	<4E917A6B.1010200@emcraft.com>
	<201110091156.47437.vapier@gentoo.org>
Message-ID: <4E9763C7.1040100@emcraft.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Mike,

On 09.10.2011 19:56, Mike Frysinger wrote:
>> arm926ejs doesn't have {invalidate,flush}_dcache_range(), so we have to
>> add this not to break the driver on DaVinci boards (maybe we need to add
>> empty cache functions on arm926ejs instead?)
> 
> if the prototype is in include/common.h, then code may assume it exists.  if 
> it doesn't exist for a particular cpu, then that cpu is broken and common code 
> (which is what drivers/ is) should not be adding hacks to workaround broken 
> cpus.  please add stubs to the cpu you're referring to and drop the 
> DAVINCI_EMAC_DCACHE define.  or let whoever cares about that cpu add the 
> defines, but still drop DAVINCI_EMAC_DCACHE.

Ok, I've dropped DAVINCI_EMAC_DCACHE (please see my v2 patches) but now
all DaVinci boards using this driver are broken...

Regards, Ilya.