From: Helmut Raiger <helmut.raiger@hale.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] video: Moving mx3fb.c to CONFIG_VIDEO
Date: Fri, 14 Oct 2011 08:37:48 +0200 [thread overview]
Message-ID: <4E97D8BC.9030902@hale.at> (raw)
In-Reply-To: <1318497389-13726-2-git-send-email-agust@denx.de>
On 10/13/2011 11:16 AM, Anatolij Gustschin wrote:
> From: Helmut Raiger<helmut.raiger@hale.at>
>
> mx3fb.c was based on CONFIG_LCD and is moved by this patch to
> CONFIG_VIDEO, which has greater freedom in selecting videomodes
> even at runtime.
>
> This renders the accumulating list of display defines
> (CONFIG_DISPLAY_VBEST..., CONFIG_DISPLAY_C057...) obsolete as
> these may be setup through env variables:
>
> uboot> setenv mydisplay 'video=ctfb:x:240,y:320,depth:16,mode:0,pclk:185925,
> le:9,ri:17,up:7,lo:10,hs:1,vs:1,sync:100663296,vmode:0'
> uboot> setenv videomode ${mydisplay}
>
> This commit also fixes the board config files for qong and
> imx31_phycore boards as needed. The videomode settings of
> previously supported displays are added to CONFIG_EXTRA_ENV_SETTINGS
> now. CONFIG_SYS_MALLOC_LEN for imx31_phycore board is increased
> to make the frame buffer allocation working with the changed
> driver.
>
> Signed-off-by: Helmut Raiger<helmut.raiger@hale.at>
> Signed-off-by: Anatolij Gustschin<agust@denx.de>
> Cc: Stefano Babic<sbabic@denx.de>
> ---
> Changes since v2:
> - fixed commit message
> - added display info for removed display timings of
> previously supported displays (in a comment)
> - fixed compiler warning showed when compiling with debug
> enabled
> - added "Video: " prefix before display info output (as
> we usually do it in U-Boot)
> - fixed board config files for 'qong' and 'imx31_phycore' boards
> so that this commit doesn't break compiling (bisectable now)
> - added videomode settings for previously supported displays on
> 'qong' and 'imx31_phycore' to CONFIG_EXTRA_ENV_SETTINGS
> - increased CONFIG_SYS_MALLOC_LEN for 'imx31_phycore' so that
> the frame buffer can be allocated now (this is required to make
> the display support working with the changed mx3fb driver)
>
Hi Anatolij,
I'm fine with your changes. It still works on our board. Thanks for
testing and improving.
Helmut
--
Scanned by MailScanner.
next prev parent reply other threads:[~2011-10-14 6:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 13:41 [U-Boot] Moving mx3fb.c to CONFIG_VIDEO Helmut Raiger
2011-08-22 13:41 ` [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available Helmut Raiger
2011-08-22 14:00 ` Marek Vasut
2011-08-22 15:00 ` Helmut Raiger
2011-08-22 15:02 ` Marek Vasut
2011-08-22 15:51 ` Helmut Raiger
2011-08-22 16:02 ` Marek Vasut
2011-08-22 16:39 ` Marek Vasut
2011-08-24 6:55 ` Helmut Raiger
2011-08-24 12:35 ` Marek Vasut
2011-08-22 16:22 ` Stefano Babic
2011-08-22 13:41 ` [U-Boot] [PATCH 2/2] mx3fb: move to CONFIG_VIDEO to support videomodes Helmut Raiger
2011-08-22 17:13 ` Stefano Babic
2011-08-24 11:53 ` Helmut Raiger
2011-08-24 15:34 ` Helmut Raiger
2011-08-24 15:45 ` Stefano Babic
[not found] ` <4E549AC3.3060909@hale.at>
2011-08-24 11:57 ` Helmut Raiger
2011-08-22 16:04 ` [U-Boot] Moving mx3fb.c to CONFIG_VIDEO Stefano Babic
2011-09-05 11:47 ` [U-Boot] Version 2 of 'Moving mx3fb to CONFIG_VIDEO' Helmut Raiger
2011-09-05 11:47 ` [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available Helmut Raiger
2011-09-05 13:10 ` Marek Vasut
2011-09-05 11:47 ` [U-Boot] [PATCH 2/2] Moving mx3fb.c to CONFIG_VIDEO Helmut Raiger
2011-09-20 11:44 ` Stefano Babic
2011-09-20 12:36 ` Anatolij Gustschin
2011-09-20 13:09 ` Stefano Babic
2011-09-21 8:02 ` Helmut Raiger
2011-09-21 14:58 ` Stefano Babic
2011-09-28 17:24 ` Anatolij Gustschin
2011-10-13 9:16 ` [U-Boot] [PATCH v3 1/2] mx31: make HSP clock for mx3fb driver available Anatolij Gustschin
2011-10-13 9:23 ` Anatolij Gustschin
2011-10-13 9:40 ` Stefano Babic
2011-10-14 7:02 ` Anatolij Gustschin
2011-10-13 9:16 ` [U-Boot] [PATCH v3 2/2] video: Moving mx3fb.c to CONFIG_VIDEO Anatolij Gustschin
2011-10-14 6:37 ` Helmut Raiger [this message]
2011-10-14 7:00 ` Anatolij Gustschin
2011-10-14 7:04 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E97D8BC.9030902@hale.at \
--to=helmut.raiger@hale.at \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox