From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 14 Oct 2011 09:51:22 +0200 Subject: [U-Boot] [PATCH 01/15 V3] iMX28: Initial support for iMX28 CPU In-Reply-To: <201110132014.55510.marek.vasut@gmail.com> References: <1317131135-22354-1-git-send-email-marek.vasut@gmail.com> <1317375728-23802-1-git-send-email-marek.vasut@gmail.com> <4E970FA0.2020505@denx.de> <201110132014.55510.marek.vasut@gmail.com> Message-ID: <4E97E9FA.50808@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/13/2011 08:14 PM, Marek Vasut wrote: > > Hi Stefano, > > the patch is big and will need approval to be let into ML. Removing the space in > char * const argv[] shall do the trick, can you please do that by hand ? I have absolutely no intention to push patches without beeing reviewed by ML, but I would like to prepare a branch with all your M28 patches to check consistency with the rest of code. Running checkpatch on your patches I see a lot of issues, and not only a couple of them. For example, WARNING: line over 80 characters #632: FILE: arch/arm/cpu/arm926ejs/mx28/mx28.c:150: +int do_mx28_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) WARNING: line over 80 characters #5415: FILE: arch/arm/include/asm/arch-mx28/iomux-mx28.h:23: + * BANK PIN MUX WARNING: line over 80 characters #5418: FILE: arch/arm/include/asm/arch-mx28/iomux-mx28.h:26: +#define MX28_PAD_GPMI_D00__GPMI_D0 MXS_IOMUX_PAD_NAKED(0, 0, PAD_MUXSEL_0) Running checkpatch on all your patches I get 488 warnings. Can you check and fix them ? Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================