From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sun, 16 Oct 2011 00:34:37 +0400 Subject: [U-Boot] [PATCH 2/4] arm, davinci: Correct the MDSTAT.STATE mask In-Reply-To: <1318419080-14396-3-git-send-email-christian.riesch@omicron.at> References: <1318419080-14396-1-git-send-email-christian.riesch@omicron.at> <1318419080-14396-3-git-send-email-christian.riesch@omicron.at> Message-ID: <4E99EE5D.5090508@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. On 12-10-2011 15:31, Christian Riesch wrote: > MDSTAT.STATE occupies bits 0..5 according to all available documentation, > therefore change the bitmask to 0x3f. > Signed-off-by: Christian Riesch > Cc: Heiko Schocher > Cc: Paulraj Sandeep > Cc: Albert ARIBAUD > Cc: Sergei Shtylyov > --- > arch/arm/cpu/arm926ejs/davinci/psc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > diff --git a/arch/arm/cpu/arm926ejs/davinci/psc.c b/arch/arm/cpu/arm926ejs/davinci/psc.c > index 8273a7f..486adb0 100644 > --- a/arch/arm/cpu/arm926ejs/davinci/psc.c > +++ b/arch/arm/cpu/arm926ejs/davinci/psc.c > @@ -83,7 +83,7 @@ void lpsc_on(unsigned int id) > while (readl(ptstat)& 0x01) > continue; > > - if ((readl(mdstat)& 0x1f) == 0x03) > + if ((readl(mdstat)& 0x3f) == 0x03) > return; /* Already on and enabled */ > > writel(readl(mdctl) | 0x03, mdctl); > @@ -114,7 +114,7 @@ void lpsc_on(unsigned int id) > > while (readl(ptstat)& 0x01) > continue; > - while ((readl(mdstat)& 0x1f) != 0x03) > + while ((readl(mdstat)& 0x3f) != 0x03) > continue; > } This patch is incomplete but I guess you've figured that out already as you've commented on my analogous patch. So marking for the custodian -- don't apply this patch. WBR, Sergei