From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Grinberg <grinberg@compulab.co.il>
Date: Sun, 16 Oct 2011 10:11:35 +0200
Subject: [U-Boot] [PATCH 6/8] AM35xx: add EMAC support
In-Reply-To: <4E97EA0A.3090603@emcraft.com>
References: <1318540312-24777-1-git-send-email-yanok@emcraft.com>	<1318540312-24777-7-git-send-email-yanok@emcraft.com>	<201110131855.59960.vapier@gentoo.org>
	<4E97EA0A.3090603@emcraft.com>
Message-ID: <4E9A91B7.8010400@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10/14/11 09:51, Ilya Yanok wrote:
> Hi Mike,
> 
> On 14.10.2011 02:55, Mike Frysinger wrote:
>>> --- /dev/null
>>> +++ b/arch/arm/cpu/armv7/omap3/emac.c
>>>
>>> +/*
>>> + * Initializes on-chip ethernet controllers.
>>> + * to override, implement board_eth_init()
>>> + */
>>> +int cpu_eth_init(bd_t *bis)
>>> +{
>>> +	davinci_emac_initialize();
>>> +
>>> +	return 0;
>>> +}
>>
>> shouldn't emac support always be up to the board porter and not the SoC code ?  
> 
> It's up to the board porter to define CONFIG_DRIVER_TI_EMAC (or not),
> isn't it enough?

Yes, it should be enough, especially in case of EMAC on Davinci and AM35x,
when this IP block is always present inside the SoC.

> 
>> also, this should be:
>> int cpu_eth_init(bd_t *bis)
>> {
>> 	return davinci_emac_initialize();
>> }
> 
> Agreed.
> 
> Regards, Ilya.
> 
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 

-- 
Regards,
Igor.