From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/8] mcx: support for HTKW mcx board
Date: Sun, 16 Oct 2011 10:42:00 +0200 [thread overview]
Message-ID: <4E9A98D8.5000400@compulab.co.il> (raw)
In-Reply-To: <1318540312-24777-9-git-send-email-yanok@emcraft.com>
Hi Ilya,
On 10/13/11 23:11, Ilya Yanok wrote:
> This patch adds support for the HTKW mcx AM3517-based board.
> Serial, Ethernet, NAND and MMC are supported.
>
> Requires updated mach-types file.
>
> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
> ---
[...]
> diff --git a/board/htkw/mcx/mcx.c b/board/htkw/mcx/mcx.c
> new file mode 100644
> index 0000000..00bd564
> --- /dev/null
> +++ b/board/htkw/mcx/mcx.c
[...]
> +
> +#define AM3517_IP_SW_RESET 0x48002598
> +#define CPGMACSS_SW_RST (1 << 1)
[...]
> +int misc_init_r(void)
> +{
> +#if defined(CONFIG_DRIVER_TI_EMAC)
> + u32 reset;
> +#endif
> +
> + dieid_num_r();
> +
> +#if defined(CONFIG_DRIVER_TI_EMAC)
> + /* ensure that the module is out of reset */
> + reset = readl(AM3517_IP_SW_RESET);
> + reset &= ~CPGMACSS_SW_RST;
> + writel(reset, AM3517_IP_SW_RESET);
> +
> +#endif
> + return 0;
> +}
I don't really insist, but couldn't the EMAC reset be handled
in the cpu_eth_init() function, instead of each board does
the reset itself?
[...]
--
Regards,
Igor.
next prev parent reply other threads:[~2011-10-16 8:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 21:11 [U-Boot] [PATCH 0/8][v2] DaVinci EMAC for AM35x and HTKW mcx board support Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 1/8] davinci_emac: move arch-independent defines to separate header Ilya Yanok
2011-10-13 22:56 ` Mike Frysinger
2011-10-13 21:11 ` [U-Boot] [PATCH 2/8] davinci_emac: use internal addresses in buffer descriptors Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 3/8] davinci_emac: conditionally compile specific PHY support Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 4/8] davinci_emac: fix for running with dcache enabled Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 5/8] davinci_emac: hardcode 100Mbps for AM35xx and RMII Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 6/8] AM35xx: add EMAC support Ilya Yanok
2011-10-13 22:55 ` Mike Frysinger
2011-10-14 7:51 ` Ilya Yanok
2011-10-16 8:11 ` Igor Grinberg
2011-10-17 22:32 ` [U-Boot] [PATCH 6/8][v3] " Ilya Yanok
2011-10-13 21:11 ` [U-Boot] [PATCH 7/8] AM3517: move AM3517 specific mux defines to generic header Ilya Yanok
2011-10-16 8:15 ` Igor Grinberg
2011-10-13 21:11 ` [U-Boot] [PATCH 8/8] mcx: support for HTKW mcx board Ilya Yanok
2011-10-13 22:56 ` Mike Frysinger
2011-10-17 22:25 ` [U-Boot] [PATCH] AM35xx: add EMAC support Ilya Yanok
2011-10-17 22:28 ` Ilya Yanok
2011-10-17 22:37 ` [U-Boot] [PATCH 8/8][v3] mcx: support for HTKW mcx board Ilya Yanok
2011-10-16 8:42 ` Igor Grinberg [this message]
2011-10-17 22:34 ` [U-Boot] [PATCH 8/8] " Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9A98D8.5000400@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox