From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Grinberg <grinberg@compulab.co.il>
Date: Sun, 16 Oct 2011 10:42:00 +0200
Subject: [U-Boot] [PATCH 8/8] mcx: support for HTKW mcx board
In-Reply-To: <1318540312-24777-9-git-send-email-yanok@emcraft.com>
References: <1318540312-24777-1-git-send-email-yanok@emcraft.com>
	<1318540312-24777-9-git-send-email-yanok@emcraft.com>
Message-ID: <4E9A98D8.5000400@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Ilya,

On 10/13/11 23:11, Ilya Yanok wrote:
> This patch adds support for the HTKW mcx AM3517-based board.
> Serial, Ethernet, NAND and MMC are supported.
> 
> Requires updated mach-types file.
> 
> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
> ---

[...]

> diff --git a/board/htkw/mcx/mcx.c b/board/htkw/mcx/mcx.c
> new file mode 100644
> index 0000000..00bd564
> --- /dev/null
> +++ b/board/htkw/mcx/mcx.c

[...]

> +
> +#define AM3517_IP_SW_RESET	0x48002598
> +#define CPGMACSS_SW_RST		(1 << 1)

[...]

> +int misc_init_r(void)
> +{
> +#if defined(CONFIG_DRIVER_TI_EMAC)
> +	u32 reset;
> +#endif
> +
> +	dieid_num_r();
> +
> +#if defined(CONFIG_DRIVER_TI_EMAC)
> +	/* ensure that the module is out of reset */
> +	reset = readl(AM3517_IP_SW_RESET);
> +	reset &= ~CPGMACSS_SW_RST;
> +	writel(reset, AM3517_IP_SW_RESET);
> +
> +#endif
> +	return 0;
> +}

I don't really insist, but couldn't the EMAC reset be handled
in the cpu_eth_init() function, instead of each board does
the reset itself?

[...]


-- 
Regards,
Igor.