From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sun, 16 Oct 2011 14:57:36 +0200 Subject: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads In-Reply-To: <1318742050-2201-2-git-send-email-sjg@chromium.org> References: <1318742050-2201-1-git-send-email-sjg@chromium.org> <1318742050-2201-2-git-send-email-sjg@chromium.org> Message-ID: <4E9AD4C0.7060409@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, Le 16/10/2011 07:14, Simon Glass a ?crit : > From: Scott Wood > > From: Scott Wood > > This improves the performance of U-Boot when accepting rapid input, > such as pasting a sequence of commands. > > Without this patch, on P4080DS I see a maximum of around 5 lines can > be pasted. With this patch, it handles around 70 lines before lossage, > long enough for most things you'd paste. > > With it enabled, on ppc it's an extra 396 bytes of image size, and 1056 > bytes of BSS. > > ARM note from Simon Glass - ARM code size goes from > 212 to 484 bytes (extra 272 bytes), BSS to 1056 bytes. > > Signed-off-by: Scott Wood > --- > Changes in v2: > - Fix checkpatch warnings, the other one was already there > > Changes in v3: > - Use CONFIG_NS16550_BUFFER_READS to set the buffer size also > > Changes in v4: > - Change config option to CONFIG_NS16550_RBUF_SIZE > - Add additional checkpatch-cleanup patch Hmm... What about the conversation around V2 of the patch re: using XOFF/XON to control input flow? IIUC, even this V4 patch would not help much if there is a command within the pasted code that sends a lot of output, right? Amicalement, -- Albert.