From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7] omap/spl: don't assume u-boot.bin size, use CONFIG_SYS_NAND_U_BOOT_SIZE
Date: Tue, 18 Oct 2011 03:50:47 +0400 [thread overview]
Message-ID: <4E9CBF57.6090604@emcraft.com> (raw)
In-Reply-To: <CA+M6bXnSui0D5JrTTrWtVfjt5AEUzBvh61tR+OPxjMeWXZW39A@mail.gmail.com>
Hi Tom,
On 18.10.2011 03:43, Tom Rini wrote:
>> Don't hardcode u-boot.bin size for the case where mkimage signature is
>> missing, use CONFIG_SYS_NAND_U_BOOT_SIZE for this.
>>
>> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
>
> I don't like this since it means we need to always define this
> variable when well behaved situations will have shipped u-boot.img
> anyhow. Or is there really a good reason
> to fall back to u-boot.bin?
No, I don't think so. I got your point. Still I think hardcoding the
size value is not very good solution either. Maybe we can add something like
#ifndef CONFIG_SYS_NAND_U_BOOT_SIZE
#define CONFIG_SYS_NAND_U_BOOT_SIZE (200 * 1024) /* 200kB - default */
#endif
?
Regards, Ilya.
next prev parent reply other threads:[~2011-10-17 23:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 23:33 [U-Boot] [PATCH 0/7] NAND SPL support for mcx board Ilya Yanok
2011-10-17 23:33 ` [U-Boot] [PATCH 1/7] omap3/emif4: fix registers definition Ilya Yanok
2011-10-17 23:33 ` [U-Boot] [PATCH 2/7] omap/spl: don't assume u-boot.bin size, use CONFIG_SYS_NAND_U_BOOT_SIZE Ilya Yanok
2011-10-17 23:43 ` Tom Rini
2011-10-17 23:50 ` Ilya Yanok [this message]
2011-10-31 12:38 ` Ilya Yanok
2011-10-31 14:43 ` Tom Rini
2011-10-17 23:33 ` [U-Boot] [PATCH 3/7] omap/spl: actually enable the console Ilya Yanok
2011-10-19 19:24 ` Tom Rini
2011-10-31 12:39 ` Ilya Yanok
2011-10-31 14:44 ` Tom Rini
2011-10-17 23:33 ` [U-Boot] [PATCH 4/7] nand_spl_simple: add support for software ECC Ilya Yanok
2011-10-17 23:33 ` [U-Boot] [PATCH 5/7] omap_gpmc: use SOFTECC in SPL if it's enabled Ilya Yanok
2011-10-20 12:00 ` Simon Schwarz
2011-10-20 15:23 ` Ilya Yanok
2011-10-21 11:08 ` Simon Schwarz
2011-10-27 20:27 ` Ilya Yanok
2011-10-31 17:30 ` Ilya Yanok
2011-10-17 23:33 ` [U-Boot] [PATCH 6/7] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE Ilya Yanok
2011-10-17 23:33 ` [U-Boot] [PATCH 7/7] mcx: NAND SPL support Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9CBF57.6090604@emcraft.com \
--to=yanok@emcraft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox