From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Yanok Date: Tue, 18 Oct 2011 03:50:47 +0400 Subject: [U-Boot] [PATCH 2/7] omap/spl: don't assume u-boot.bin size, use CONFIG_SYS_NAND_U_BOOT_SIZE In-Reply-To: References: <1318894433-9038-1-git-send-email-yanok@emcraft.com> <1318894433-9038-3-git-send-email-yanok@emcraft.com> Message-ID: <4E9CBF57.6090604@emcraft.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On 18.10.2011 03:43, Tom Rini wrote: >> Don't hardcode u-boot.bin size for the case where mkimage signature is >> missing, use CONFIG_SYS_NAND_U_BOOT_SIZE for this. >> >> Signed-off-by: Ilya Yanok > > I don't like this since it means we need to always define this > variable when well behaved situations will have shipped u-boot.img > anyhow. Or is there really a good reason > to fall back to u-boot.bin? No, I don't think so. I got your point. Still I think hardcoding the size value is not very good solution either. Maybe we can add something like #ifndef CONFIG_SYS_NAND_U_BOOT_SIZE #define CONFIG_SYS_NAND_U_BOOT_SIZE (200 * 1024) /* 200kB - default */ #endif ? Regards, Ilya.