From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [STATUS] "Quality" of patches / testing.
Date: Tue, 18 Oct 2011 11:22:26 +0200 [thread overview]
Message-ID: <4E9D4552.5040506@gmail.com> (raw)
In-Reply-To: <4E9D21F8.40100@gmail.com>
Dear Simon,
Am 18.10.2011 08:51, schrieb Simon Schwarz:
> Hi Wolfgang,
>
> On 10/18/2011 08:23 AM, Wolfgang Denk wrote:
> [SNIP]
>>
>> Why is nobody doing this?
>
> One of my big problems with this was that you not only have to run a
> MAKEALL with your own changes but also have to do that with the former
> state of the repo to identifie the differences.
We should first get a state of "all boards build clean" for a sort of
toolchains (I think arm is now at this state after a lot of tumult in
the last two releases).
> So one suggestion I have is to do at least a reference build of each
> custodian repo and store the output somewhere so one can diff with these.
This is some kind of CI as suggested by Lukasz Majewski. I also favor CI
for fast feedback to the submitter if his change breaks something.
There was already a suggestion by Graeme Russ to run checkpatch on every
submitted patch. While this requires really low computing power it will
produce a lot of mail overhead. The second suggestion by Graeme was to
add an marker into the patch which states this patch as checkpatch-clean.
If we would build some CI system with automatic build we will need even
more computing power to build each patch with all/a subset of MAKEALL.
Not to mention the mail overhead for clean/broken patches. Therefor some
marker in the patch could do the job here again.
I guess it will be doable to have some scripts/prepare-patch which runs
a) git format-patch
b) checkpatch on the patch
c) (configurable subset of) MAKEALL on some clean tree with that patch
applied
d) append the results to the patch
This tool would implement some kind of CI but utilize the computing
power of submitter.
best regards
Andreas Bie?mann
next prev parent reply other threads:[~2011-10-18 9:22 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 6:23 [U-Boot] [STATUS] "Quality" of patches / testing Wolfgang Denk
2011-10-18 6:51 ` Simon Schwarz
2011-10-18 9:22 ` Andreas Bießmann [this message]
2011-10-18 9:44 ` Wolfgang Denk
2011-10-18 13:05 ` Jason
2011-10-18 13:10 ` Jason
2011-10-18 13:13 ` Simon Schwarz
2011-10-18 13:49 ` Jason
2011-10-18 15:37 ` Jason
2011-10-18 16:12 ` Mike Frysinger
2011-10-18 13:36 ` Andreas Bießmann
2011-10-18 15:55 ` Jason
2011-10-18 14:05 ` Simon Glass
2011-10-18 16:59 ` Anton Staaf
2011-10-18 20:23 ` Wolfgang Denk
2011-10-20 0:39 ` Simon Glass
2011-10-20 15:32 ` Wolfgang Denk
2011-10-18 10:24 ` Lukasz Majewski
2011-10-18 11:02 ` Wolfgang Denk
2011-10-18 9:34 ` Wolfgang Denk
2011-10-18 13:05 ` Simon Schwarz
2011-10-18 8:49 ` Lukasz Majewski
2011-10-18 17:01 ` [U-Boot] MAKEALL Mike Frysinger
2011-10-18 17:39 ` Simon Glass
2011-10-18 17:58 ` Tom Rini
2011-10-18 18:11 ` Mike Frysinger
2011-10-18 18:31 ` Mike Frysinger
2011-10-18 18:54 ` Tom Rini
2011-10-18 19:49 ` Mike Frysinger
2011-10-18 20:07 ` Wolfgang Denk
2011-10-18 20:14 ` Mike Frysinger
2011-10-18 20:47 ` Wolfgang Denk
2011-10-18 20:55 ` Mike Frysinger
2011-10-18 21:30 ` Simon Glass
2011-10-18 22:21 ` Mike Frysinger
2011-10-19 11:36 ` Albert ARIBAUD
2011-10-19 14:25 ` Mike Frysinger
2011-10-19 19:57 ` Wolfgang Denk
2011-10-18 21:50 ` Wolfgang Denk
2011-10-18 22:18 ` Mike Frysinger
2011-10-18 22:33 ` Graeme Russ
2011-10-19 7:12 ` Andreas Bießmann
2011-10-19 8:57 ` Wolfgang Denk
2011-10-18 17:16 ` [U-Boot] [STATUS] "Quality" of patches / testing Anton Staaf
2011-10-18 17:44 ` Albert ARIBAUD
2011-10-18 18:07 ` Anton Staaf
2011-10-20 9:25 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9D4552.5040506@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox