From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= Date: Tue, 18 Oct 2011 15:36:21 +0200 Subject: [U-Boot] [STATUS] "Quality" of patches / testing. In-Reply-To: <20111018130507.GR7102@titan.lakedaemon.net> References: <20111018062310.61320140797D@gemini.denx.de> <4E9D21F8.40100@gmail.com> <4E9D4552.5040506@gmail.com> <20111018094437.C16201408E9C@gemini.denx.de> <20111018130507.GR7102@titan.lakedaemon.net> Message-ID: <4E9D80D5.7090304@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jason, Am 18.10.2011 15:05, schrieb Jason: > Wolfgang, > > On Tue, Oct 18, 2011 at 11:44:37AM +0200, Wolfgang Denk wrote: >> Dear Andreas, >> >> In message <4E9D4552.5040506@gmail.com> you wrote: >>> I guess it will be doable to have some scripts/prepare-patch which runs >>> a) git format-patch >>> b) checkpatch on the patch >>> c) (configurable subset of) MAKEALL on some clean tree with that patch >>> applied >>> d) append the results to the patch >>> >>> This tool would implement some kind of CI but utilize the computing >>> power of submitter. >> >> Sounds good. Any takers? > > I've been mulling this over, and here's my approach: > > 1.) modify git to add a hook in format-patch, output is dumped after the > '---' and before the diff. We use this the run checkpatch.pl with our > config. Our script includes a version tag of checkpatch.pl? I think of some script that utilizes git rather than changing git. > 2.) Add a '--versioning' option to format-patch which will scan the > output directory for previous versions of the patch. nice, but ... > a.) Use the Message-Id of the first version as an In-Reply-To > b.) Migrate patch changelog over from previous version, append '*** > ADD CHANGELOG ENTRY HERE ***' > c.) enforce [PATCH 1/7 V#] Subject line format. I never hold old patches long, they are on the list, patchwork or in my tree. But feel free to discuss this on git ML. And I doubt this will help us in near future (remember the debian users ;) Best regards Andreas Bie?mann