[U-Boot] [PATCH V2 05/13] i2c: Create common default i2c_set_bus_num() function

Heiko Schocher
2011-10-10T10:33:07Z

Hello Stefano,

Stefano Babic wrote:
> New default, weak i2c_set_bus_num() function.
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> Changes since V1:
>
> - add a weak function i2c_set_bus_num() to cmd_i2c.c instead of adding a
> dummy function to mxc_i2c.c. (Heiko Schocher)
>
> common/cmd_i2c.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
> index 3ea75f7..0f925d1 100644
> --- a/common/cmd_i2c.c
> +++ b/common/cmd_i2c.c
> @@ -158,6 +158,14 @@ int __def_i2c_set_bus_speed(unsigned int speed)
> int i2c_set_bus_speed(unsigned int)
> __attribute__((weak, alias("__def_i2c_set_bus_speed")));
>
> +int __def_i2c_set_bus_num(unsigned int bus)
> +{
> + return 0;
> +}
> +int i2c_set_bus_num(unsigned int)
> + __attribute__((weak, alias("__def_i2c_set_bus_num")));
> +
> +

Please just one new line ;-)

Beside of this, you get my:

Acked-by: Heiko Schocher <hs@denx.de>

> /*
> * get_alen: small parser helper function to get address length
> * returns the address length

Thanks!

bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany