public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Richard Retanubun <RichardRetanubun@ruggedcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] disk: part_efi: fix **pgpt_pte == NULL
Date: Wed, 19 Oct 2011 15:33:47 -0400	[thread overview]
Message-ID: <4E9F261B.70609@RuggedCom.com> (raw)
In-Reply-To: <1319047487-9926-2-git-send-email-dianders@chromium.org>

On 10/19/11 14:04, Doug Anderson wrote:
> Code was setting **pgpt_pte == NULL, which meant that the pointer
> to the gpt_pte would be stored at RAM address 00000000. This 'worked'
> on T20 (SDRAM starts @ 0x00000000), but hung gpt/EFI access on T30
> (SDRAM starts @ 0x80000000).
>
> Signed-off-by: Tom Warren<twarren@nvidia.com>
> Signed-off-by: Doug Anderson<dianders@chromium.org>
> ---
> This was inspired by a change that I obtained through Tom Warren
> at nVidia.
>
>   disk/part_efi.c |   36 ++++++++++++++++++------------------
>   1 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/disk/part_efi.c b/disk/part_efi.c
> index 6a139a9..08bd560 100644
> --- a/disk/part_efi.c
> +++ b/disk/part_efi.c
> @@ -121,7 +121,7 @@ static char *print_efiname(gpt_entry *pte)
>   void print_part_efi(block_dev_desc_t * dev_desc)
>   {
>   	gpt_header gpt_head;
> -	gpt_entry **pgpt_pte = NULL;
> +	gpt_entry *gpt_pte = NULL;
>   	int i = 0;

ACK, good find!

- Richard

  parent reply	other threads:[~2011-10-19 19:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-19 18:04 [U-Boot] [PATCH 1/2] cosmetic: Replace __FUNCTION__ with __func__ in part_efi.c Doug Anderson
2011-10-19 18:04 ` [U-Boot] [PATCH 2/2] disk: part_efi: fix **pgpt_pte == NULL Doug Anderson
2011-10-19 18:21   ` Mike Frysinger
2011-10-19 19:47     ` Doug Anderson
2011-10-19 19:56       ` Mike Frysinger
2011-10-19 19:59         ` Doug Anderson
2011-10-19 20:29           ` Mike Frysinger
2011-10-27 21:50       ` Wolfgang Denk
2011-10-19 19:33   ` Richard Retanubun [this message]
2011-10-19 18:19 ` [U-Boot] [PATCH 1/2] cosmetic: Replace __FUNCTION__ with __func__ in part_efi.c Mike Frysinger
2011-10-19 19:24 ` Richard Retanubun
2011-10-27 21:46 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9F261B.70609@RuggedCom.com \
    --to=richardretanubun@ruggedcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox