From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helmut Raiger Date: Thu, 20 Oct 2011 08:41:02 +0200 Subject: [U-Boot] [PATCH] misc: pmic: fix regression in pmic_fsl.c (SPI) In-Reply-To: <4E9F0595.9090302@denx.de> References: <4E9EEF2C.9050906@denx.de> <1319042932-25508-1-git-send-email-helmut.raiger@hale.at> <4E9F0595.9090302@denx.de> Message-ID: <4E9FC27E.3030208@hale.at> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/19/2011 07:15 PM, Stefano Babic wrote: > > This fixes the issue with the Freescale PMIC, but... > > The new driver introduces a level of abstraction to make easier to > introduce other PMICs that are driven with SPI / I2C. For this reason, > PMIC specific code must be inside the specific driver (pmic_fsl.c) and > not in the general (pmic_core.c and pmic_spi.c). And clearing the MSB is > part of the Freescale's protocol, and for this reason should be moved > inside the prepare function. > > Best regards, > Stefano Babic > Ah yes, I stumbled over git again (and again and again). :-[ See [Resend V2]. Helmut -- Scanned by MailScanner.