From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] BOARD_LATE_INIT <-> CONFIG_BOARD_LATE_INIT
Date: Thu, 20 Oct 2011 09:38:27 +0200 [thread overview]
Message-ID: <4E9FCFF3.7030900@denx.de> (raw)
In-Reply-To: <4E9FCAFA.7060909@hale.at>
On 10/20/2011 09:17 AM, Helmut Raiger wrote:
> Hi,
>
Hi Helmut,
> is there a sound reason, why BOARD_LATE_INIT isn't named like
> other CONFIG options? I'm inclined to fix this as it took me some time
> to find out why my board_late_init() wasn't called.
I assume that the name was not changed when all defines got the
CONFIG_SYS prefix, so we had for example FLASH_SIZE instead of
CONFIG_SYS_FLASH_SIZE as now. Surely it is not coherent with the rest of
code, so I vote for fixing it.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-10-20 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 7:17 [U-Boot] BOARD_LATE_INIT <-> CONFIG_BOARD_LATE_INIT Helmut Raiger
2011-10-20 7:38 ` Stefano Babic [this message]
2011-10-20 9:53 ` [U-Boot] [PATCH] cosmetic: s/BOARD_LATE_INIT/CONFIG_BOARD_LATE_INIT Helmut Raiger
2011-10-20 10:12 ` Stefano Babic
[not found] ` <4EA00331.9060004@hale.at>
2011-10-20 11:27 ` Stefano Babic
2011-10-20 14:19 ` [U-Boot] [PATCH V2] " Helmut Raiger
2011-10-27 12:25 ` Helmut Raiger
2011-10-27 12:42 ` Stefano Babic
2011-10-27 21:51 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9FCFF3.7030900@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox