From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chou Date: Fri, 21 Oct 2011 15:21:30 +0800 Subject: [U-Boot] [PATCH 1/2] gpio: Add driver for Altera's PIO core In-Reply-To: <1318865809-1310-2-git-send-email-joachim.foerster@missinglinkelectronics.com> References: <1318865809-1310-1-git-send-email-joachim.foerster@missinglinkelectronics.com> <1318865809-1310-2-git-send-email-joachim.foerster@missinglinkelectronics.com> Message-ID: <4EA11D7A.50105@wytron.com.tw> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/17/2011 11:36 PM, Joachim Foerster wrote: > This driver may handle multiple PIO cores and thus needs to be > setup by calling the altera_pio_init() function within the early > board setup routine. > > The driver comes with some extras, see below the copyleft header. > > Signed-off-by: Joachim Foerster > --- > arch/nios2/include/asm/gpio.h | 13 +- > board/altera/nios2-generic/custom_fpga.h | 1 + > board/altera/nios2-generic/nios2-generic.c | 8 + > drivers/gpio/Makefile | 1 + > drivers/gpio/altera_pio.c | 299 ++++++++++++++++++++++++++++ > 5 files changed, 320 insertions(+), 2 deletions(-) > create mode 100644 drivers/gpio/altera_pio.c Hi Joachim, Please fix these warning. Thanks. $ ./MAKEALL nios2-generic Configuring for nios2-generic board... altera_pio.c: In function `altera_pio_info': altera_pio.c:189: warning: ` ' flag used with `%u' printf format checkpatch.pl ERROR: do not initialise statics to 0 or NULL #209: FILE: drivers/gpio/altera_pio.c:71: +static int pio_num = 0; ERROR: do not initialise statics to 0 or NULL #217: FILE: drivers/gpio/altera_pio.c:79: +static int pio_gpio_num = 0; Otherwise, Tested-by: Thomas Chou Best regards, Thomas