From: Joachim Foerster <joachim.foerster@missinglinkelectronics.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] gpio: Add driver for Altera's PIO core
Date: Fri, 21 Oct 2011 15:49:38 +0200 [thread overview]
Message-ID: <4EA17872.3040607@missinglinkelectronics.com> (raw)
In-Reply-To: <4EA11D7A.50105@wytron.com.tw>
On 10/21/2011 09:21 AM, Thomas Chou wrote:
> On 10/17/2011 11:36 PM, Joachim Foerster wrote:
>> This driver may handle multiple PIO cores and thus needs to be
>> setup by calling the altera_pio_init() function within the early
>> board setup routine.
>>
>> The driver comes with some extras, see below the copyleft header.
>>
>> Signed-off-by: Joachim
>> Foerster<joachim.foerster@missinglinkelectronics.com>
>> ---
>> arch/nios2/include/asm/gpio.h | 13 +-
>> board/altera/nios2-generic/custom_fpga.h | 1 +
>> board/altera/nios2-generic/nios2-generic.c | 8 +
>> drivers/gpio/Makefile | 1 +
>> drivers/gpio/altera_pio.c | 299 ++++++++++++++++++++++++++++
>> 5 files changed, 320 insertions(+), 2 deletions(-)
>> create mode 100644 drivers/gpio/altera_pio.c
>
> Hi Joachim,
>
> Please fix these warning. Thanks.
>
> $ ./MAKEALL nios2-generic
> Configuring for nios2-generic board...
> altera_pio.c: In function `altera_pio_info':
> altera_pio.c:189: warning: ` ' flag used with `%u' printf format
Ok, I'll use %d - in this case it is the same. Does anybody know why %u
warns about space-flag usage? Is space-flag + %u indeed evil ?
> Otherwise,
> Tested-by: Thomas Chou <thomas@wytron.com.tw>
>
> Best regards,
> Thomas
Thanks for reviewing.
--
Joachim Foerster
Missing Link Electronics
http://www.missinglinkelectronics.com
Office EU: +49 (731) 141-149-0
Office US: +1 (408) 457-0700
email: joachim.foerster at missinglinkelectronics.com
next prev parent reply other threads:[~2011-10-21 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 15:36 [U-Boot] [PATCH 0/2] Replace nios2-generic's gpio.c with dedicated driver Joachim Foerster
2011-10-17 15:36 ` [U-Boot] [PATCH 1/2] gpio: Add driver for Altera's PIO core Joachim Foerster
2011-10-21 7:21 ` Thomas Chou
2011-10-21 13:48 ` [U-Boot] [PATCH 0/2] Replace nios2-generic's gpio.c with dedicated driver Joachim Foerster
2011-10-21 13:48 ` [U-Boot] [PATCH 1/2 v2] gpio: Add driver for Altera's PIO core Joachim Foerster
2011-10-28 7:29 ` Thomas Chou
2011-10-21 13:48 ` [U-Boot] [PATCH 2/2 v2] board/nios2-generic: Use altera_pio driver and remove board specific driver Joachim Foerster
2011-10-28 7:29 ` Thomas Chou
2011-10-21 13:49 ` Joachim Foerster [this message]
2011-10-17 15:36 ` [U-Boot] [PATCH 2/2] " Joachim Foerster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA17872.3040607@missinglinkelectronics.com \
--to=joachim.foerster@missinglinkelectronics.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox