From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joachim Foerster Date: Fri, 21 Oct 2011 15:49:38 +0200 Subject: [U-Boot] [PATCH 1/2] gpio: Add driver for Altera's PIO core In-Reply-To: <4EA11D7A.50105@wytron.com.tw> References: <1318865809-1310-1-git-send-email-joachim.foerster@missinglinkelectronics.com> <1318865809-1310-2-git-send-email-joachim.foerster@missinglinkelectronics.com> <4EA11D7A.50105@wytron.com.tw> Message-ID: <4EA17872.3040607@missinglinkelectronics.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/21/2011 09:21 AM, Thomas Chou wrote: > On 10/17/2011 11:36 PM, Joachim Foerster wrote: >> This driver may handle multiple PIO cores and thus needs to be >> setup by calling the altera_pio_init() function within the early >> board setup routine. >> >> The driver comes with some extras, see below the copyleft header. >> >> Signed-off-by: Joachim >> Foerster >> --- >> arch/nios2/include/asm/gpio.h | 13 +- >> board/altera/nios2-generic/custom_fpga.h | 1 + >> board/altera/nios2-generic/nios2-generic.c | 8 + >> drivers/gpio/Makefile | 1 + >> drivers/gpio/altera_pio.c | 299 ++++++++++++++++++++++++++++ >> 5 files changed, 320 insertions(+), 2 deletions(-) >> create mode 100644 drivers/gpio/altera_pio.c > > Hi Joachim, > > Please fix these warning. Thanks. > > $ ./MAKEALL nios2-generic > Configuring for nios2-generic board... > altera_pio.c: In function `altera_pio_info': > altera_pio.c:189: warning: ` ' flag used with `%u' printf format Ok, I'll use %d - in this case it is the same. Does anybody know why %u warns about space-flag usage? Is space-flag + %u indeed evil ? > Otherwise, > Tested-by: Thomas Chou > > Best regards, > Thomas Thanks for reviewing. -- Joachim Foerster Missing Link Electronics http://www.missinglinkelectronics.com Office EU: +49 (731) 141-149-0 Office US: +1 (408) 457-0700 email: joachim.foerster at missinglinkelectronics.com