public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] Small refactor to remove duplicate serial code
@ 2011-09-13 22:32 Simon Glass
  2011-09-14  2:39 ` Mike Frysinger
  2011-10-21 22:27 ` Wolfgang Denk
  0 siblings, 2 replies; 6+ messages in thread
From: Simon Glass @ 2011-09-13 22:32 UTC (permalink / raw)
  To: u-boot

This tidies up duplicate code, and checks that default_serial_console() does
in fact produce a device.

Acked-by: Mike Frysinger <vapier@gentoo.org>

Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
- Rebase to master

 common/serial.c |   61 +++++++++++++++++-------------------------------------
 1 files changed, 19 insertions(+), 42 deletions(-)

diff --git a/common/serial.c b/common/serial.c
index 995d268..2bd8976 100644
--- a/common/serial.c
+++ b/common/serial.c
@@ -158,73 +158,50 @@ void serial_reinit_all (void)
 	}
 }
 
-int serial_init (void)
+static struct serial_device *get_current(void)
 {
+	struct serial_device *dev;
+
 	if (!(gd->flags & GD_FLG_RELOC) || !serial_current) {
-		struct serial_device *dev = default_serial_console ();
+		dev = default_serial_console();
 
-		return dev->init ();
+		/* We must have a console device */
+		if (!dev)
+			panic("Cannot find console");
+	} else {
+		dev = serial_current;
 	}
+	return dev;
+}
 
-	return serial_current->init ();
+int serial_init(void)
+{
+	return get_current()->init();
 }
 
 void serial_setbrg (void)
 {
-	if (!(gd->flags & GD_FLG_RELOC) || !serial_current) {
-		struct serial_device *dev = default_serial_console ();
-
-		dev->setbrg ();
-		return;
-	}
-
-	serial_current->setbrg ();
+	get_current()->setbrg();
 }
 
 int serial_getc (void)
 {
-	if (!(gd->flags & GD_FLG_RELOC) || !serial_current) {
-		struct serial_device *dev = default_serial_console ();
-
-		return dev->getc ();
-	}
-
-	return serial_current->getc ();
+	return get_current()->getc();
 }
 
 int serial_tstc (void)
 {
-	if (!(gd->flags & GD_FLG_RELOC) || !serial_current) {
-		struct serial_device *dev = default_serial_console ();
-
-		return dev->tstc ();
-	}
-
-	return serial_current->tstc ();
+	return get_current()->tstc();
 }
 
 void serial_putc (const char c)
 {
-	if (!(gd->flags & GD_FLG_RELOC) || !serial_current) {
-		struct serial_device *dev = default_serial_console ();
-
-		dev->putc (c);
-		return;
-	}
-
-	serial_current->putc (c);
+	get_current()->putc(c);
 }
 
 void serial_puts (const char *s)
 {
-	if (!(gd->flags & GD_FLG_RELOC) || !serial_current) {
-		struct serial_device *dev = default_serial_console ();
-
-		dev->puts (s);
-		return;
-	}
-
-	serial_current->puts (s);
+	get_current()->puts(s);
 }
 
 #if CONFIG_POST & CONFIG_SYS_POST_UART
-- 
1.7.3.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-10-21 23:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-13 22:32 [U-Boot] [PATCH v2] Small refactor to remove duplicate serial code Simon Glass
2011-09-14  2:39 ` Mike Frysinger
2011-10-21 22:27 ` Wolfgang Denk
2011-10-21 22:30   ` Simon Glass
2011-10-21 22:42     ` Albert ARIBAUD
2011-10-21 23:27     ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox