From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] at91: Add support for Bluewater Systems Snapper 9G45 module
Date: Sun, 23 Oct 2011 05:57:46 +0200 [thread overview]
Message-ID: <4EA390BA.8010607@emk-elektronik.de> (raw)
In-Reply-To: <1319339348-2959-1-git-send-email-sglass@bluewatersys.com>
Dear Simon Glass,
> Snapper 9G45 is a ARM9-based CPU module with 1GB NAND and 128MB
> DDR SDRAM. This patch includes NAND and Ethernet support.
>
> Signed-off-by: Simon Glass<sglass@bluewatersys.com>
> ---
> board/bluewater/snapper9g45/Makefile | 43 +++++++
> board/bluewater/snapper9g45/snapper9g45.c | 155 +++++++++++++++++++++++
> boards.cfg | 1 +
> include/configs/snapper9g45.h | 189 +++++++++++++++++++++++++++++
> 4 files changed, 388 insertions(+), 0 deletions(-)
> create mode 100644 board/bluewater/snapper9g45/Makefile
> create mode 100644 board/bluewater/snapper9g45/snapper9g45.c
> create mode 100644 include/configs/snapper9g45.h
>
> [...]
> +
> +#ifndef NEW
> +#define CONFIG_PCA953X
> +#define CONFIG_SYS_I2C_PCA953X_ADDR 0x28
> +#define CONFIG_SYS_I2C_PCA953X_WIDTH { {0x28, 16} }
> +#endif
if that is a board variant, use something better than just "NEW" -
and where would that ever get defined?
> +/* Command line configuration */
> +#include<config_cmd_default.h>
Space missing here.
Please run checkpatch before submitting!
Best Regards,
Reinhard
next prev parent reply other threads:[~2011-10-23 3:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 3:09 [U-Boot] [PATCH] at91: Add support for Bluewater Systems Snapper 9G45 module Simon Glass
2011-10-23 3:57 ` Reinhard Meyer [this message]
2011-11-01 14:44 ` Simon Glass
2011-11-01 15:22 ` [U-Boot] [PATCH v2] " Simon Glass
2011-11-01 20:38 ` Andre Renaud
2011-11-02 9:32 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA390BA.8010607@emk-elektronik.de \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox