From mboxrd@z Thu Jan  1 00:00:00 1970
From: Reinhard Meyer <u-boot@emk-elektronik.de>
Date: Sun, 23 Oct 2011 05:57:46 +0200
Subject: [U-Boot] [PATCH] at91: Add support for Bluewater Systems
 Snapper 9G45 module
In-Reply-To: <1319339348-2959-1-git-send-email-sglass@bluewatersys.com>
References: <1319339348-2959-1-git-send-email-sglass@bluewatersys.com>
Message-ID: <4EA390BA.8010607@emk-elektronik.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Simon Glass,
> Snapper 9G45 is a ARM9-based CPU module with 1GB NAND and 128MB
> DDR SDRAM. This patch includes NAND and Ethernet support.
>
> Signed-off-by: Simon Glass<sglass@bluewatersys.com>
> ---
>   board/bluewater/snapper9g45/Makefile      |   43 +++++++
>   board/bluewater/snapper9g45/snapper9g45.c |  155 +++++++++++++++++++++++
>   boards.cfg                                |    1 +
>   include/configs/snapper9g45.h             |  189 +++++++++++++++++++++++++++++
>   4 files changed, 388 insertions(+), 0 deletions(-)
>   create mode 100644 board/bluewater/snapper9g45/Makefile
>   create mode 100644 board/bluewater/snapper9g45/snapper9g45.c
>   create mode 100644 include/configs/snapper9g45.h
>
> [...]
> +
> +#ifndef NEW
> +#define CONFIG_PCA953X
> +#define CONFIG_SYS_I2C_PCA953X_ADDR	0x28
> +#define CONFIG_SYS_I2C_PCA953X_WIDTH	{ {0x28, 16} }
> +#endif

if that is a board variant, use something better than just "NEW" -
and where would that ever get defined?

> +/* Command line configuration */
> +#include<config_cmd_default.h>

Space missing here.

Please run checkpatch before submitting!

Best Regards,
Reinhard