From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cosmetic, post: Codingstyle cleanup
Date: Mon, 24 Oct 2011 07:18:28 +0200 [thread overview]
Message-ID: <4EA4F524.1050304@denx.de> (raw)
In-Reply-To: <20111021223122.A45E211F9E79@gemini.denx.de>
Hello Wolfgang,
Wolfgang Denk schrieb:
> Dear Heiko Schocher,
>
> In message <1316064766-5385-1-git-send-email-hs@denx.de> you wrote:
>> + else
>> /* Use old value */
>> newword = post_word_load () & ~POST_COLDBOOT;
>> - }
> ...
>> if (bootmode == 0)
>> - {
>> /* We are booting after power-on */
>> newword |= POST_COLDBOOT;
>> - }
>
> In U-Boot we rewuire braces around multiline comments (even though
> checkpatch does not complain about this).
>
> Please fix and resubmit.
This is already fixed here:
http://patchwork.ozlabs.org/patch/119184/
and found this patch already applied to u-boot-arm, here:
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=095bd94ad54bb407459862129ad8cd23367b2a03
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2011-10-24 5:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 5:32 [U-Boot] [PATCH] cosmetic, post: Codingstyle cleanup Heiko Schocher
2011-10-12 11:18 ` [U-Boot] [PATCH v2] " Heiko Schocher
2011-10-21 22:31 ` [U-Boot] [PATCH] " Wolfgang Denk
2011-10-24 5:18 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA4F524.1050304@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox