From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 24 Oct 2011 07:18:28 +0200 Subject: [U-Boot] [PATCH] cosmetic, post: Codingstyle cleanup In-Reply-To: <20111021223122.A45E211F9E79@gemini.denx.de> References: <1316064766-5385-1-git-send-email-hs@denx.de> <20111021223122.A45E211F9E79@gemini.denx.de> Message-ID: <4EA4F524.1050304@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, Wolfgang Denk schrieb: > Dear Heiko Schocher, > > In message <1316064766-5385-1-git-send-email-hs@denx.de> you wrote: >> + else >> /* Use old value */ >> newword = post_word_load () & ~POST_COLDBOOT; >> - } > ... >> if (bootmode == 0) >> - { >> /* We are booting after power-on */ >> newword |= POST_COLDBOOT; >> - } > > In U-Boot we rewuire braces around multiline comments (even though > checkpatch does not complain about this). > > Please fix and resubmit. This is already fixed here: http://patchwork.ozlabs.org/patch/119184/ and found this patch already applied to u-boot-arm, here: http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=095bd94ad54bb407459862129ad8cd23367b2a03 bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany