public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] FIX for dcache_disable() for ARM926ej-s
Date: Mon, 24 Oct 2011 23:49:12 +0200	[thread overview]
Message-ID: <4EA5DD58.3090505@aribaud.net> (raw)
In-Reply-To: <1319179460-5625-1-git-send-email-b.van.den.berg.nl@gmail.com>

Hi Bas,

Le 21/10/2011 08:44, Bas van den Berg a ?crit :
> the cache also needs to be invalidated, not just flushed, Since re-enabling it,
> can cause inconsistent data without invalidation. See example below.
>
> in c-file:
> static int num = 1;
>
> void test() {
>      num = 1;
>      dcache_enable();
>      printf("Cache on, num=%d\n", num);
>      num = 2;
>      dcache_disable();
>      printf("Cache off, num=%d\n", num);
>      num = 1;
>      dcache_enable();
>      printf("Cache on, num=%d\n", num);  // ->  prints 2 instead of 1!!
>      dcache_disable();
>      printf("Cache off, num=%d\n", num);
> }

This part of the patch is what will stay in the GIT tree as the commit 
message. Here it is too verbose. Remove useless example.

Amicalement,
-- 
Albert.

      parent reply	other threads:[~2011-10-24 21:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21  6:44 [U-Boot] [PATCH] FIX for dcache_disable() for ARM926ej-s Bas van den Berg
2011-10-21 12:08 ` Sergei Shtylyov
2011-10-24 21:49 ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA5DD58.3090505@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox