From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 25 Oct 2011 08:15:32 +0200 Subject: [U-Boot] [PATCH V2 0/4] add mmc support for pantheon platform In-Reply-To: References: <1317632545-12410-1-git-send-email-leiwen@marvell.com> <1317710024-9484-1-git-send-email-leiwen@marvell.com> <4EA59E54.8040202@aribaud.net> Message-ID: <4EA65404.9080408@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Lei Wen, Le 25/10/2011 03:21, Lei Wen a ?crit : > Hi Albert, > > On Tue, Oct 25, 2011 at 1:20 AM, Albert ARIBAUD > wrote: >> Hi Lei Wen, >> >> Le 04/10/2011 08:33, Lei Wen a ?crit : >>> This patch seris add the mmc support for the pantheon platform. >>> Also give platform like dkb and aspenite a workaround when enabling >>> the 8bit mode for accessing the mmc. >>> >>> Changelog: >>> V2: remove magic number, and replace it by macro definition and structure >>> respectively. >>> remove enable mmc function into seperated patch >>> >>> Lei Wen (4): >>> ARM: pantheon: add mmc definition >>> Marvell: dkb: add mmc support >>> dkb: make mmc command as default enabled >>> mmc: mv_sdhci: fix 8bus width access for 88SV331xV5 >> >> This causes a lot of build errors on dkb with ELDK42: >> >> Configuring for dkb board... >> In file included from mv_sdhci.c:3: >> /home/uboot/src/u-boot-arm/include/sdhci.h:224: warning: 'struct >> sdhci_host' declared inside parameter list >> /home/uboot/src/u-boot-arm/include/sdhci.h:224: warning: its scope is >> only this definition or declaration, which is probably not what you want >> /home/uboot/src/u-boot-arm/include/sdhci.h:225: warning: 'struct >> sdhci_host' declared inside parameter list >> /home/uboot/src/u-boot-arm/include/sdhci.h:226: warning: 'struct >> sdhci_host' declared inside parameter list >> /home/uboot/src/u-boot-arm/include/sdhci.h:227: warning: 'struct >> sdhci_host' declared inside parameter list >> /home/uboot/src/u-boot-arm/include/sdhci.h:228: warning: 'struct >> sdhci_host' declared inside parameter list >> /home/uboot/src/u-boot-arm/include/sdhci.h:229: warning: 'struct >> sdhci_host' declared inside parameter list >> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_writel': >> /home/uboot/src/u-boot-arm/include/sdhci.h:247: warning: passing >> argument 1 of 'host->ops->write_l' from incompatible pointer type >> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_writew': >> /home/uboot/src/u-boot-arm/include/sdhci.h:255: warning: passing >> argument 1 of 'host->ops->write_w' from incompatible pointer type >> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_writeb': >> /home/uboot/src/u-boot-arm/include/sdhci.h:263: warning: passing >> argument 1 of 'host->ops->write_b' from incompatible pointer type >> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_readl': >> /home/uboot/src/u-boot-arm/include/sdhci.h:271: warning: passing >> argument 1 of 'host->ops->read_l' from incompatible pointer type >> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_readw': >> /home/uboot/src/u-boot-arm/include/sdhci.h:279: warning: passing >> argument 1 of 'host->ops->read_w' from incompatible pointer type >> /home/uboot/src/u-boot-arm/include/sdhci.h: In function 'sdhci_readb': >> /home/uboot/src/u-boot-arm/include/sdhci.h:287: warning: passing >> argument 1 of 'host->ops->read_b' from incompatible pointer type >> mv_sdhci.c: In function 'mv_sdhci_writeb': >> mv_sdhci.c:14: error: 'struct sdhci_host' has no member named 'mmc' >> mv_sdhci.c:17: warning: implicit declaration of function 'IS_SD' >> mv_sdhci.c:18: error: dereferencing pointer to incomplete type >> mv_sdhci.c: In function 'mv_sdh_init': >> mv_sdhci.c:48: warning: assignment from incompatible pointer type >> > > Actually, I have post another fixing series before this, so if it got > be applied before this merged, > the warning would be disappeared. > > You could refer to: > http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/111621 Thanks for the pointer -- please next time indicate the dependency on any patch set not yet applied at the time. > Best regards, > Lei Amicalement, -- Albert.