From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 25 Oct 2011 08:52:47 +0200 Subject: [U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch In-Reply-To: <20111024191357.079A014094B3@gemini.denx.de> References: <1319415273-3915-1-git-send-email-sjg@chromium.org> <1319427875-29965-1-git-send-email-sjg@chromium.org> <20111024191357.079A014094B3@gemini.denx.de> Message-ID: <4EA65CBF.7060704@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, Le 24/10/2011 21:13, Wolfgang Denk a ?crit : > Dear Simon Glass, > > In message<1319427875-29965-1-git-send-email-sjg@chromium.org> you wrote: >> Commit dc8bbea removed a local variable that is used in most ARM boards. >> >> Since we want to avoid an 'unused variable' warning with later compilers, >> and the #ifdef logic of whether this variable is required is bit painful, >> this declares the variable local to the block of code that needs it. >> >> Signed-off-by: Simon Glass >> --- >> Changes in v2: >> - Tidy up to call getenv() in declaration >> >> arch/arm/lib/board.c | 12 ++++++++---- >> 1 files changed, 8 insertions(+), 4 deletions(-) > > Applied, thanks. > > Best regards, > > Wolfgang Denk I've just fetched u-boot and I don't see this one. Can you push u-boot/master so that I can rebase u-boot-arm/master on it and launch some tests? Amicalement, -- Albert.