From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 26 Oct 2011 08:17:53 +0200 Subject: [U-Boot] [PATCH v4 08/11] arm, davinci: add lowlevel function for dm365 soc In-Reply-To: References: <1319441913-27233-1-git-send-email-hs@denx.de> <1319441913-27233-9-git-send-email-hs@denx.de> Message-ID: <4EA7A611.2010900@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Christian, Christian Riesch wrote: > Good morning Heiko, > > On Monday, October 24, 2011, Heiko Schocher wrote: > > [...] > >> arch/arm/cpu/arm926ejs/davinci/dm365_lowlevel.c | 466 > ++++++++++++++++++++ >> arch/arm/include/asm/arch-davinci/dm365_lowlevel.h | 43 ++ >> 2 files changed, 509 insertions(+), 0 deletions(-) >> create mode 100644 arch/arm/cpu/arm926ejs/davinci/dm365_lowlevel.c >> create mode 100644 arch/arm/include/asm/arch-davinci/dm365_lowlevel.h >> >> diff --git a/arch/arm/cpu/arm926ejs/davinci/dm365_lowlevel.c > b/arch/arm/cpu/arm926ejs/davinci/dm365_lowlevel.c >> new file mode 100644 >> index 0000000..d7c6a3e >> --- /dev/null >> +++ b/arch/arm/cpu/arm926ejs/davinci/ > > [...] > >> +void dm365_lpc_transition(unsigned char module, unsigned char domain, >> + unsigned char state) >> +{ > > [...] > >> + dm365_lpc_transition(LPSC_DDR2, 0, PSC_ENABLE); > > [...] > >> + /* Set the DDR2 to synreset, then enable it again */ >> + dm365_lpc_transition(LPSC_DDR2, 0, PSC_SYNCRESET); >> + dm365_lpc_transition(LPSC_DDR2, 0, PSC_ENABLE); >> + > > dm365.c from the same directory uses lpsc_on(). Could you also use this > function (and lpsc_syncreset from [1]) and remove dm365_lpc_transition > instead? Yes, you are right, I try this, thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany