From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/10 v3] spl, nand: add 4bit HW ecc oob first nand_read_page function
Date: Wed, 26 Oct 2011 11:58:20 -0500 [thread overview]
Message-ID: <4EA83C2C.6060101@freescale.com> (raw)
In-Reply-To: <4EA7A5D2.8010806@denx.de>
On 10/26/2011 01:16 AM, Heiko Schocher wrote:
> Hello Scott,
>
> Scott Wood wrote:
>> It's not new, but it is misnamed (there's nothing 4-bit specific in the
>> #ifdeffed code), and we now have someone that wants this for 8-bit ECC.
>
> look at my v4 series of this patchset:
>
> http://patchwork.ozlabs.org/patch/121295/
>
> I renamed it to: CONFIG_SYS_NAND_HW_ECC_OOBFIRST
OK. I just got back from vacation, so I'm still going through an e-mail
backlog.
> In drivers/mtd/nand/davinci_nand.c CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST
> is used, and there are 4bit specific functions, so this define is
> also valid, just we need in drivers/mtd/nand/nand_spl_simple.c a more
> common name, right?
Right. Ideally, though, that would either be CONFIG_SYS_DAVINCI_... or
#if defined(CONFIG_SYS_NAND_HW_ECC_OOBFIRST) && \
defined(CONFIG_SYS_NAND_HW_ECC_4BIT)
-Scott
next prev parent reply other threads:[~2011-10-26 16:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 14:28 [U-Boot] [PATCH v2 05/10] spl, nand: add 4bit HW ecc oob first nand_read_page function Heiko Schocher
2011-10-05 21:45 ` Scott Wood
2011-10-06 5:41 ` Heiko Schocher
2011-10-06 5:45 ` [U-Boot] [PATCH 05/10 v3] " Heiko Schocher
2011-10-06 16:05 ` Tom Rini
2011-10-10 21:17 ` Scott Wood
2011-10-11 5:41 ` Heiko Schocher
2011-10-11 5:49 ` Wolfgang Denk
2011-10-25 15:24 ` Scott Wood
2011-10-26 6:16 ` Heiko Schocher
2011-10-26 16:58 ` Scott Wood [this message]
2011-10-27 5:23 ` Heiko Schocher
2011-10-27 18:14 ` Scott Wood
2011-10-28 6:05 ` Heiko Schocher
2011-10-28 16:03 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA83C2C.6060101@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox