From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Wed, 26 Oct 2011 11:58:20 -0500
Subject: [U-Boot] [PATCH 05/10 v3] spl,
 nand: add 4bit HW ecc oob first nand_read_page function
In-Reply-To: <4EA7A5D2.8010806@denx.de>
References: <1317824907-8693-1-git-send-email-hs@denx.de>
	<1317879924-18266-1-git-send-email-hs@denx.de>
	<4E9360E7.3030205@freescale.com> <4E93D6FF.9020408@denx.de>
	<4EA6D492.4040003@freescale.com> <4EA7A5D2.8010806@denx.de>
Message-ID: <4EA83C2C.6060101@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10/26/2011 01:16 AM, Heiko Schocher wrote:
> Hello Scott,
> 
> Scott Wood wrote:
>> It's not new, but it is misnamed (there's nothing 4-bit specific in the
>> #ifdeffed code), and we now have someone that wants this for 8-bit ECC.
> 
> look at my v4 series of this patchset:
> 
> http://patchwork.ozlabs.org/patch/121295/
> 
> I renamed it to: CONFIG_SYS_NAND_HW_ECC_OOBFIRST

OK.  I just got back from vacation, so I'm still going through an e-mail
backlog.

> In drivers/mtd/nand/davinci_nand.c CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST
> is used, and there are 4bit specific functions, so this define is
> also valid, just we need in drivers/mtd/nand/nand_spl_simple.c a more
> common name, right?

Right.  Ideally, though, that would either be CONFIG_SYS_DAVINCI_... or
#if defined(CONFIG_SYS_NAND_HW_ECC_OOBFIRST) && \
    defined(CONFIG_SYS_NAND_HW_ECC_4BIT)

-Scott