public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] OMAP3 SPL: Rework memory initalization and devkit 8000 support
Date: Thu, 27 Oct 2011 14:00:41 -0700	[thread overview]
Message-ID: <4EA9C679.10406@ti.com> (raw)
In-Reply-To: <4EA9C335.4030204@compulab.co.il>

On 10/27/2011 01:46 PM, Igor Grinberg wrote:
> Hi Tom,
> 
> That seems like a good change, though I would recommend to split it into
> smaller
> patches, please, see below:
> 
> On 10/26/2011 11:13 PM, Tom Rini wrote:
>> This changes to making the board be responsible for providing the
>> memory initialization timings in SPL
> 
> That probably would be one patch.
> 
>>  and converts the devkit 8000
>> to this framework.
> 
> That, would be another one.

But breaking it up like this breaks bisect'ability as devkit8000 builds
today (well, outside of the scope of this series).

>>   As part of this suffix the Micron DDR settings
>> with their speed
> 
> Next patch.

OK.

> 
>>  and add a few more timing values that will be needed.
> 
> This can go along with the patch that uses those settings.

I'll double check where they're really neded.

>> We also make sure that in mem_ok() we clear the values off as we may be
>> testing the same banks multiple times.
> 
> That's should be another patch (although it has only one line).

Sure.  Again, the bigger picture right now I'm hoping for is:
(a) does it work on all of the other beagleboard revs?  The logic is a
little twisty but it's what x-loader does today and (b) does the overall
approach look sane to everyone?

Thanks!

-- 
Tom

  reply	other threads:[~2011-10-27 21:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26 21:13 [U-Boot] [PATCH RFT 0/2] Beagleboard SPL support Tom Rini
2011-10-26 21:13 ` [U-Boot] [PATCH 1/2] OMAP3 SPL: Rework memory initalization and devkit 8000 support Tom Rini
2011-10-27 20:46   ` Igor Grinberg
2011-10-27 21:00     ` Tom Rini [this message]
2011-10-27 21:27       ` Igor Grinberg
2011-10-26 21:13 ` [U-Boot] [PATCH 2/2] OMAP3: Add SPL support to Beagleboard Tom Rini
2011-10-27 12:46   ` Premi, Sanjeev
2011-10-27 17:08     ` Tom Rini
2011-10-27 21:18   ` Igor Grinberg
2011-10-27 21:27     ` Wolfgang Denk
2011-10-27 23:02       ` Igor Grinberg
2011-10-27 23:19         ` Scott Wood
2011-10-27 23:35           ` Igor Grinberg
2011-10-27 21:29     ` Tom Rini
2011-10-27 23:10       ` Igor Grinberg
2011-10-27 23:13         ` Tom Rini
2011-10-27 23:22           ` Scott Wood
2011-10-27 23:33             ` Tom Rini
2011-10-28 16:00               ` Scott Wood
2011-10-28 16:29                 ` Tom Rini
2011-10-28 16:42                   ` Scott Wood
2011-10-28 16:56                     ` Tom Rini
2011-11-04 16:50             ` Tom Rini
2011-11-01 14:46     ` Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2011-10-04 14:59 [U-Boot] [PATCH 0/2]: OMAP3 SPL updates Tom Rini
2011-10-04 14:59 ` [U-Boot] [PATCH 1/2] OMAP3 SPL: Rework memory initalization and devkit 8000 support Tom Rini
2011-10-06 21:08   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA9C679.10406@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox