From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 6/6] net: Export auto_load, use it in rarp
Date: Thu, 27 Oct 2011 18:09:18 -0500 [thread overview]
Message-ID: <4EA9E49E.1080602@freescale.com> (raw)
In-Reply-To: <CAJaTeTrrUt_9XUTJW-15Aes6a_POauR-TWvnxVwUHJ+1=w06ZA@mail.gmail.com>
On 10/27/2011 05:40 PM, Mike Frysinger wrote:
> On Fri, Oct 28, 2011 at 00:24, Simon Glass wrote:
>> On Thu, Oct 27, 2011 at 2:12 PM, Mike Frysinger wrote:
>>> On Thu, Oct 27, 2011 at 18:24, Simon Glass wrote:
>>>> This also fixes an incorrect call to TftpStart() which was never seen
>>>> since apparently no boards enable rarp.
>>>
>>> i wonder if we shouldn't just drop rarp then if no one actually uses it ...
>>
>> Well that's the definition of dead code, but of course there may be
>> thousands of boards out there that use it, where the code is not
>> upstream. I suppose we could take the code out and see if anyone
>> notices :-) It is at least in a separate file and not built unless
>> requested.
>
> i think our (reasonable) position is that if no one is using it, and
> no one is noticing when it breaks, then we should simply drop it. if
> out of tree boards cared, they'd be in tree.
For features like this that are user-enableable, rather than e.g. a
board code dependency, it's users that care, not boards. I don't think
we're asking people to submit a variant "board" config with their own
personal preferences/requirements, if they differ from the board
maintainer's. Unfortunately U-Boot lacks the ability to do an
"allyesconfig" to at least build-test such features.
Of course, if it's actually been broken for a while, that suggests that
the users don't care either. :-) Or perhaps are running older versions,
but might upgrade at some point.
It's probably best to follow the normal feature removal process to see
if anyone's interested in maintaining it, before removing it.
-Scott
next prev parent reply other threads:[~2011-10-27 23:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 16:24 [U-Boot] [PATCH v2 0/6] Reduce code size of libnet Simon Glass
2011-10-27 16:24 ` [U-Boot] [PATCH v2 1/6] net: Hide more code behind CONFIG_CMD_TFTPPUT Simon Glass
2011-10-27 21:13 ` Mike Frysinger
2011-10-27 21:38 ` Wolfgang Denk
2011-10-27 16:24 ` [U-Boot] [PATCH v2 2/6] net: Make net_transfer() a static function Simon Glass
2011-10-27 21:11 ` Mike Frysinger
2011-10-27 21:38 ` Wolfgang Denk
2011-10-27 16:24 ` [U-Boot] [PATCH v2 3/6] net: Add more #ifdefs for tftpput to reduce code size Simon Glass
2011-10-27 21:39 ` Wolfgang Denk
2011-10-27 16:24 ` [U-Boot] [PATCH v2 4/6] net: Change for loop to memset() Simon Glass
2011-10-27 21:09 ` Mike Frysinger
2011-10-27 21:39 ` Wolfgang Denk
2011-10-27 16:24 ` [U-Boot] [PATCH v2 5/6] net: Be less picky about decoding the netretry env var Simon Glass
2011-10-27 21:40 ` Wolfgang Denk
2011-10-27 21:45 ` Simon Glass
2011-10-27 16:24 ` [U-Boot] [PATCH v2 6/6] net: Export auto_load, use it in rarp Simon Glass
2011-10-27 21:12 ` Mike Frysinger
2011-10-27 22:24 ` Simon Glass
2011-10-27 22:40 ` Mike Frysinger
2011-10-27 23:09 ` Scott Wood [this message]
2011-10-27 23:22 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA9E49E.1080602@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox