From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 28 Oct 2011 09:29:08 -0700 Subject: [U-Boot] [PATCH 2/2] OMAP3: Add SPL support to Beagleboard In-Reply-To: <4EAAD198.9050504@freescale.com> References: <1319663618-10005-1-git-send-email-trini@ti.com> <1319663618-10005-3-git-send-email-trini@ti.com> <4EA9CA9D.6010209@compulab.co.il> <4EA9CD2F.1060306@ti.com> <4EA9E4E1.6040603@compulab.co.il> <4EA9E5B1.3080801@ti.com> <4EA9E7B0.8030407@freescale.com> <4EA9EA3C.6000802@ti.com> <4EAAD198.9050504@freescale.com> Message-ID: <4EAAD854.1050706@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/28/2011 09:00 AM, Scott Wood wrote: > On 10/27/2011 06:33 PM, Tom Rini wrote: >> On 10/27/2011 04:22 PM, Scott Wood wrote: >>> On 10/27/2011 06:13 PM, Tom Rini wrote: >>>> OK, so, Scott, where would you suggest we put a very trivial set of nand >>>> infrastructure we need outside of the scope of loading u-boot itself >>>> from NAND ? >>> >>> Can the SPL code be used (not an actual SPL build, just the NAND code >>> associated with it)? >> >> As-is, no, it'll fail to compile unless you fill in a number of blanks >> about ECC and so forth. > > "...with appropriate refactoring" was implied. :-) > >> If we split nand_spl_simple.c in two, we might >> be able to re-use nand_command there (maybe with some re-thinking of the >> #if logic for big or small pages). Give me filenames and I'll do the >> work :) > > Pick whatever name you think makes sense given what's going to be in it. nand_spl_{cmd,read}.c ? _cmd gets the two nand_command() funcs, _read gets everything else. Work for you? -- Tom