public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pm9261: add mach-type localy for the board
Date: Fri, 28 Oct 2011 20:17:22 +0200	[thread overview]
Message-ID: <4EAAF1B2.4080701@aribaud.net> (raw)
In-Reply-To: <1319818248-27364-1-git-send-email-dimov@ronetix.at>

Hi Asen,

You should copy Ilko as the maintainer, unless you are taking over 
maintainership of this board (and pm9263 and pm9g45), in which case 
please modify MAINTAINERS file as well.

Le 28/10/2011 18:10, Asen Chavdarov Dimov a ?crit :
> Signed-off-by: Asen Chavdarov Dimov<dimov@ronetix.at>
> ---
>   board/ronetix/pm9261/mach-type.h |   31 +++++++++++++++++++++++++++++++

NAK. Do not copy-paste mach-type.h, just add the MACH_TYPE_PM9261 define 
in include/configs/pm9261.h.

>   board/ronetix/pm9261/pm9261.c    |    1 +
>   2 files changed, 32 insertions(+), 0 deletions(-)
>   create mode 100644 board/ronetix/pm9261/mach-type.h
>
> diff --git a/board/ronetix/pm9261/mach-type.h b/board/ronetix/pm9261/mach-type.h
> new file mode 100644
> index 0000000..ca07c18
> --- /dev/null
> +++ b/board/ronetix/pm9261/mach-type.h
> @@ -0,0 +1,31 @@
> +/*
> + * This was manually generated from arch/arm/include/asm/mach-types.h
> + * and add this machine ID removed with commit
> + * 47af6f61bcd9fdd5dcf389cff0a7406eba756c6.
> + * Do fix this.
> + */
> +
> +#ifndef __ASM_ARM_MACH_TYPE_PM9261_H
> +#define __ASM_ARM_MACH_TYPE_PM9261_H
> +
> +#ifndef __ASSEMBLY__
> +/* The type of machine we're running on */
> +extern unsigned int __machine_arch_type;
> +#endif
> +
> +/* see arch/arm/kernel/arch.c for a description of these */
> +#define MACH_TYPE_PM9261              1187
> +
> +#ifdef CONFIG_MACH_PM9261
> +# ifdef machine_arch_type
> +#  undef machine_arch_type
> +#  define machine_arch_type	__machine_arch_type
> +# else
> +#  define machine_arch_type	MACH_TYPE_PM9261
> +# endif
> +# define machine_is_pm9261()	(machine_arch_type == MACH_TYPE_PM9261)
> +#else
> +# define machine_is_pm9261()	(0)
> +#endif
> +
> +#endif
> diff --git a/board/ronetix/pm9261/pm9261.c b/board/ronetix/pm9261/pm9261.c
> index 871b94a..e394a93 100644
> --- a/board/ronetix/pm9261/pm9261.c
> +++ b/board/ronetix/pm9261/pm9261.c
> @@ -25,6 +25,7 @@
>    */
>
>   #include<common.h>
> +#include "mach-type.h"

NAK -- you don't need this if you add MACH_TYPE_PM9261.

>   #include<asm/sizes.h>
>   #include<asm/io.h>
>   #include<asm/arch/at91sam9_smc.h>

Same applies to the other two boards -- you can actually submit a single 
patch for all three of them.

Amicalement,
-- 
Albert.

  reply	other threads:[~2011-10-28 18:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 16:10 [U-Boot] [PATCH] pm9261: add mach-type localy for the board Asen Chavdarov Dimov
2011-10-28 18:17 ` Albert ARIBAUD [this message]
2011-10-31  8:46   ` Igor Grinberg
2011-10-31  9:04   ` RONETIX - Asen Dimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EAAF1B2.4080701@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox