public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
Date: Sun, 30 Oct 2011 11:32:43 +0100	[thread overview]
Message-ID: <4EAD27CB.9020907@aribaud.net> (raw)
In-Reply-To: <201110300047.46696.marek.vasut@gmail.com>

Hi Jens, Marek,

Le 30/10/2011 00:47, Marek Vasut a ?crit :
>> * re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
>>
>> Signed-off-by: Jens Scharsig<js_at_ng@scharsoft.de>
>> ---
>>   include/configs/eb_cpux9k2.h |    4 ++++
>>   1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/configs/eb_cpux9k2.h b/include/configs/eb_cpux9k2.h
>> index 4324172..e437f25 100644
>> --- a/include/configs/eb_cpux9k2.h
>> +++ b/include/configs/eb_cpux9k2.h
>> @@ -42,6 +42,10 @@
>>   #define CONFIG_BOARD_EARLY_INIT_F
>>
>>   /*------------------------------------------------------------------------
>> --*/
>> +#ifndef MACH_TYPE_EB_CPUX9K2
>> +#define MACH_TYPE_EB_CPUX9K2           1977
>> +#endif
>> +/*------------------------------------------------------------------------
>> --*/
>>   #define CONFIG_SYS_TEXT_BASE 		0x00000000
>>   #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
>
> You don't need the ifndef. Cheers

I'd even say you need to not have them: this way, when the MACH_ID shows 
up eventually in machine-type, the preprocessor will emit a warning for 
the redefinition in the config file, thus letting us know it is time to 
remove the temporary MACH_TYPE there.

Amicalement,
-- 
Albert.

  reply	other threads:[~2011-10-30 10:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-29 10:20 [U-Boot] [PATCH] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board Jens Scharsig
2011-10-29 22:47 ` Marek Vasut
2011-10-30 10:32   ` Albert ARIBAUD [this message]
2011-10-31  7:28     ` Jens Scharsig
2011-10-30 13:12   ` Wolfgang Denk
2011-10-30 20:14     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EAD27CB.9020907@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox