From mboxrd@z Thu Jan  1 00:00:00 1970
From: RONETIX - Asen Dimov <dimov@ronetix.at>
Date: Mon, 31 Oct 2011 11:04:02 +0200
Subject: [U-Boot] [PATCH] pm9261: add mach-type localy for the board
In-Reply-To: <4EAAF1B2.4080701@aribaud.net>
References: <1319818248-27364-1-git-send-email-dimov@ronetix.at>
	<4EAAF1B2.4080701@aribaud.net>
Message-ID: <4EAE6482.80607@ronetix.at>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Albert,

On 10/28/2011 09:17 PM, Albert ARIBAUD wrote:
> Hi Asen,
>
> You should copy Ilko as the maintainer, unless you are taking over 
> maintainership of this board (and pm9263 and pm9g45), in which case 
> please modify MAINTAINERS file as well.
Ok, I will CC: him next time.
>
> Le 28/10/2011 18:10, Asen Chavdarov Dimov a ?crit :
>> Signed-off-by: Asen Chavdarov Dimov<dimov@ronetix.at>
>> ---
>>   board/ronetix/pm9261/mach-type.h |   31 
>> +++++++++++++++++++++++++++++++
>
> NAK. Do not copy-paste mach-type.h, just add the MACH_TYPE_PM9261 
> define in include/configs/pm9261.h.
>
>>   board/ronetix/pm9261/pm9261.c    |    1 +
>>   2 files changed, 32 insertions(+), 0 deletions(-)
>>   create mode 100644 board/ronetix/pm9261/mach-type.h
...
>>   #include<common.h>
>> +#include "mach-type.h"
>
> NAK -- you don't need this if you add MACH_TYPE_PM9261.
>
>>   #include<asm/sizes.h>
>>   #include<asm/io.h>
>>   #include<asm/arch/at91sam9_smc.h>
>
> Same applies to the other two boards -- you can actually submit a 
> single patch for all three of them.
>
Ok.
> Amicalement,
Regards,
Asen