From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 05/11] arm, davinci: add support for new spl framework
Date: Mon, 31 Oct 2011 17:09:43 -0500 [thread overview]
Message-ID: <4EAF1CA7.5010403@freescale.com> (raw)
In-Reply-To: <1320036790-24283-6-git-send-email-hs@denx.de>
On 10/30/2011 11:53 PM, Heiko Schocher wrote:
> diff --git a/arch/arm/cpu/arm926ejs/davinci/spl_nand.c b/arch/arm/cpu/arm926ejs/davinci/spl_nand.c
> new file mode 100644
> index 0000000..efc0521
> --- /dev/null
> +++ b/arch/arm/cpu/arm926ejs/davinci/spl_nand.c
> @@ -0,0 +1,57 @@
> +/*
> + * Copyright (C) 2011
> + * Heiko Schocher, DENX Software Engineering, hs at denx.de.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <nand.h>
> +#include <asm/io.h>
Does this file use anything from asm/io.h?
> +/*
> + * The main entry for NAND booting. It's necessary that SDRAM is already
> + * configured and available since this code loads the main U-Boot image
> + * from NAND into SDRAM and starts it from there.
> + */
> +void nand_boot(void)
> +{
> + int ret;
> + __attribute__((noreturn)) void (*uboot)(void);
> +
> + /*
> + * Load U-Boot image from NAND into RAM
> + */
> + ret = nand_spl_load_image(CONFIG_SYS_NAND_U_BOOT_OFFS,
> + CONFIG_SYS_NAND_U_BOOT_SIZE,
> + (void *)CONFIG_SYS_NAND_U_BOOT_DST);
> +
> +#ifdef CONFIG_NAND_ENV_DST
> + ret = nand_spl_load_image(CONFIG_ENV_OFFSET, CONFIG_ENV_SIZE,
> + (void *)CONFIG_NAND_ENV_DST);
> +
> +#ifdef CONFIG_ENV_OFFSET_REDUND
> + ret = nand_spl_load_image(CONFIG_ENV_OFFSET_REDUND, CONFIG_ENV_SIZE,
> + (void *)CONFIG_NAND_ENV_DST + CONFIG_ENV_SIZE);
> +#endif
> +#endif
> +
> + /*
> + * Jump to U-Boot image
> + */
> + uboot = (void *)CONFIG_SYS_NAND_U_BOOT_START;
> + (*uboot)();
> +}
This is common to most NAND SPLs. It would be nice to stick this in a
common place (at least the loading part, maybe not the jump). Not
nand_spl_simple.c, as it's utility is not limited to the simple driver.
Maybe drivers/mtd/nand/nand_spl_load.c?
-Scott
next prev parent reply other threads:[~2011-10-31 22:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 4:52 [U-Boot] [PATCH v5 00/11] arm, davinci: add support for dm368 based cam_enc_4xx board Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 01/11] usb, davinci: add enable_vbus() weak function Heiko Schocher
2011-10-31 7:02 ` Igor Grinberg
2011-11-01 5:03 ` Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 02/11] arm, usb, davinci: make USBPHY_CTL register configurable Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 03/11] net, davinci_emac: make clock divider in MDIO control " Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 04/11] spl: add option for adding post memory test to the SPL framework Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 05/11] arm, davinci: add support for new spl framework Heiko Schocher
2011-10-31 22:09 ` Scott Wood [this message]
2011-10-31 22:34 ` Tom Rini
2011-11-01 5:06 ` Heiko Schocher
2011-11-01 15:39 ` Scott Wood
2011-10-31 4:53 ` [U-Boot] [PATCH v5 06/11] spl, nand: add 4bit HW ecc oob first nand_read_page function Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 07/11] arm, davinci: add header files for dm365 Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 08/11] arm, davinci: add lowlevel function for dm365 soc Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 09/11] arm926ejs, davinci: add cpuinfo for dm365 Heiko Schocher
2011-10-31 5:46 ` Prabhakar Lad
2011-10-31 4:53 ` [U-Boot] [PATCH v5 10/11] arm926ejs, davinci: add missing spi defines " Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 11/11] arm, davinci: add cam_enc_4xx support Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAF1CA7.5010403@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox