From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 01/11] usb, davinci: add enable_vbus() weak function
Date: Tue, 01 Nov 2011 06:03:53 +0100 [thread overview]
Message-ID: <4EAF7DB9.9030802@denx.de> (raw)
In-Reply-To: <4EAE47F7.9040501@compulab.co.il>
Hello Igor,
Igor Grinberg wrote:
> Hi Heiko,
>
> On 10/31/11 06:53, Heiko Schocher wrote:
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> Cc: Remy Bohmer <linux@bohmer.net>
>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>> Cc: Igor Grinberg <grinberg@compulab.co.il>
>>
>> ---
>> changes for v4:
>> - patch is new since v4, as Igor Grinberg suggested.
>>
>> drivers/usb/musb/davinci.c | 12 ++++++++++++
>> 1 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c
>> index f56f2df..27dc4bc 100644
>> --- a/drivers/usb/musb/davinci.c
>> +++ b/drivers/usb/musb/davinci.c
>> @@ -78,6 +78,18 @@ static void phy_off(void)
>> writel(USBPHY_OSCPDWN | USBPHY_PHYPDWN, USBPHY_CTL_PADDR);
>> }
>>
>> +#ifndef DAVINCI_DM365EVM
>> +__attribute__((weak))
>> +void enable_vbus(void)
>> +{
>> + /*
>> + * nothing to do, vbus is handled through the cpu.
>> + * Define this function in board code, if it is
>> + * different on your board.
>> + */
>> +}
>> +#endif
>
> I'd suggest, instead of closing the weak declaration inside
> ifdef/ifndef, make it available to all boards with alias.
OK, done.
Thanks for the review.
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-11-01 5:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 4:52 [U-Boot] [PATCH v5 00/11] arm, davinci: add support for dm368 based cam_enc_4xx board Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 01/11] usb, davinci: add enable_vbus() weak function Heiko Schocher
2011-10-31 7:02 ` Igor Grinberg
2011-11-01 5:03 ` Heiko Schocher [this message]
2011-10-31 4:53 ` [U-Boot] [PATCH v5 02/11] arm, usb, davinci: make USBPHY_CTL register configurable Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 03/11] net, davinci_emac: make clock divider in MDIO control " Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 04/11] spl: add option for adding post memory test to the SPL framework Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 05/11] arm, davinci: add support for new spl framework Heiko Schocher
2011-10-31 22:09 ` Scott Wood
2011-10-31 22:34 ` Tom Rini
2011-11-01 5:06 ` Heiko Schocher
2011-11-01 15:39 ` Scott Wood
2011-10-31 4:53 ` [U-Boot] [PATCH v5 06/11] spl, nand: add 4bit HW ecc oob first nand_read_page function Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 07/11] arm, davinci: add header files for dm365 Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 08/11] arm, davinci: add lowlevel function for dm365 soc Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 09/11] arm926ejs, davinci: add cpuinfo for dm365 Heiko Schocher
2011-10-31 5:46 ` Prabhakar Lad
2011-10-31 4:53 ` [U-Boot] [PATCH v5 10/11] arm926ejs, davinci: add missing spi defines " Heiko Schocher
2011-10-31 4:53 ` [U-Boot] [PATCH v5 11/11] arm, davinci: add cam_enc_4xx support Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAF7DB9.9030802@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox