From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Tue, 01 Nov 2011 06:03:53 +0100
Subject: [U-Boot] [PATCH v5 01/11] usb,
	davinci: add enable_vbus() weak function
In-Reply-To: <4EAE47F7.9040501@compulab.co.il>
References: <1320036790-24283-1-git-send-email-hs@denx.de>
	<1320036790-24283-2-git-send-email-hs@denx.de>
	<4EAE47F7.9040501@compulab.co.il>
Message-ID: <4EAF7DB9.9030802@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Igor,

Igor Grinberg wrote:
> Hi Heiko,
> 
> On 10/31/11 06:53, Heiko Schocher wrote:
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> Cc: Remy Bohmer <linux@bohmer.net>
>> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>> Cc: Igor Grinberg <grinberg@compulab.co.il>
>>
>> ---
>> changes for v4:
>> - patch is new since v4, as Igor Grinberg suggested.
>>
>>  drivers/usb/musb/davinci.c |   12 ++++++++++++
>>  1 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c
>> index f56f2df..27dc4bc 100644
>> --- a/drivers/usb/musb/davinci.c
>> +++ b/drivers/usb/musb/davinci.c
>> @@ -78,6 +78,18 @@ static void phy_off(void)
>>  	writel(USBPHY_OSCPDWN | USBPHY_PHYPDWN, USBPHY_CTL_PADDR);
>>  }
>>  
>> +#ifndef DAVINCI_DM365EVM
>> +__attribute__((weak))
>> +void enable_vbus(void)
>> +{
>> +	/*
>> +	 *  nothing to do, vbus is handled through the cpu.
>> +	 *  Define this function in board code, if it is
>> +	 *  different on your board.
>> +	 */
>> +}
>> +#endif
> 
> I'd suggest, instead of closing the weak declaration inside
> ifdef/ifndef, make it available to all boards with alias.

OK, done.

Thanks for the review.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany