public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH V2] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
@ 2011-10-31  7:26 Jens Scharsig
  2011-10-31  7:46 ` Igor Grinberg
  2011-10-31 18:52 ` [U-Boot] [PATCH V3] Arm: " Jens Scharsig
  0 siblings, 2 replies; 8+ messages in thread
From: Jens Scharsig @ 2011-10-31  7:26 UTC (permalink / raw)
  To: u-boot


* re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board

Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
---
 include/configs/eb_cpux9k2.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/configs/eb_cpux9k2.h b/include/configs/eb_cpux9k2.h
index 4324172..ad51906 100644
--- a/include/configs/eb_cpux9k2.h
+++ b/include/configs/eb_cpux9k2.h
@@ -41,6 +41,8 @@
 #define CONFIG_MISC_INIT_R
 #define CONFIG_BOARD_EARLY_INIT_F
 
+#define MACH_TYPE_EB_CPUX9K2           1977
+
 /*--------------------------------------------------------------------------*/
 #define CONFIG_SYS_TEXT_BASE 		0x00000000
 #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
-- 
1.7.3.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH V2] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
  2011-10-31  7:26 [U-Boot] [PATCH V2] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board Jens Scharsig
@ 2011-10-31  7:46 ` Igor Grinberg
  2011-10-31  8:27   ` Jens Scharsig
  2011-10-31 18:52 ` [U-Boot] [PATCH V3] Arm: " Jens Scharsig
  1 sibling, 1 reply; 8+ messages in thread
From: Igor Grinberg @ 2011-10-31  7:46 UTC (permalink / raw)
  To: u-boot

Hi Jens,

On 10/31/11 09:26, Jens Scharsig wrote:
> 
> * re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
> 
> Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
> ---
>  include/configs/eb_cpux9k2.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/eb_cpux9k2.h b/include/configs/eb_cpux9k2.h
> index 4324172..ad51906 100644
> --- a/include/configs/eb_cpux9k2.h
> +++ b/include/configs/eb_cpux9k2.h
> @@ -41,6 +41,8 @@
>  #define CONFIG_MISC_INIT_R
>  #define CONFIG_BOARD_EARLY_INIT_F
>  
> +#define MACH_TYPE_EB_CPUX9K2           1977
> +

While you are at it, probably, it will be a good time
to switch to the new standard and use the CONFIG_MACH_TYPE
option. Please, read the README file.

>  /*--------------------------------------------------------------------------*/
>  #define CONFIG_SYS_TEXT_BASE 		0x00000000
>  #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH V2] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
  2011-10-31  7:46 ` Igor Grinberg
@ 2011-10-31  8:27   ` Jens Scharsig
  2011-10-31  8:48     ` Igor Grinberg
  0 siblings, 1 reply; 8+ messages in thread
From: Jens Scharsig @ 2011-10-31  8:27 UTC (permalink / raw)
  To: u-boot

Am 2011-10-31 08:46, schrieb Igor Grinberg:
> Hi Jens,
>> @@ -41,6 +41,8 @@
>>  #define CONFIG_MISC_INIT_R
>>  #define CONFIG_BOARD_EARLY_INIT_F
>>  
>> +#define MACH_TYPE_EB_CPUX9K2           1977
>> +
> 
> While you are at it, probably, it will be a good time
> to switch to the new standard and use the CONFIG_MACH_TYPE
> option. Please, read the README file.
> 
>>  /*--------------------------------------------------------------------------*/
>>  #define CONFIG_SYS_TEXT_BASE 		0x00000000
>>  #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
> 

Dear Albert ARIBAUD,

What's your opinion?

#define MACH_TYPE_EB_CPUX9K2 1977

or

#define CONFIG_MACH_TYPE 1977

Regards Jens

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH V2] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
  2011-10-31  8:27   ` Jens Scharsig
@ 2011-10-31  8:48     ` Igor Grinberg
  2011-11-05 10:52       ` Albert ARIBAUD
  0 siblings, 1 reply; 8+ messages in thread
From: Igor Grinberg @ 2011-10-31  8:48 UTC (permalink / raw)
  To: u-boot

Hi Jens,

On 10/31/11 10:27, Jens Scharsig wrote:
> Am 2011-10-31 08:46, schrieb Igor Grinberg:
>> Hi Jens,
>>> @@ -41,6 +41,8 @@
>>>  #define CONFIG_MISC_INIT_R
>>>  #define CONFIG_BOARD_EARLY_INIT_F
>>>  
>>> +#define MACH_TYPE_EB_CPUX9K2           1977
>>> +
>>
>> While you are at it, probably, it will be a good time
>> to switch to the new standard and use the CONFIG_MACH_TYPE
>> option. Please, read the README file.
>>
>>>  /*--------------------------------------------------------------------------*/
>>>  #define CONFIG_SYS_TEXT_BASE 		0x00000000
>>>  #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
>>
> 
> Dear Albert ARIBAUD,
> 
> What's your opinion?
> 
> #define MACH_TYPE_EB_CPUX9K2 1977
> 
> or
> 
> #define CONFIG_MACH_TYPE 1977

It should be both:

#define MACH_TYPE_EB_CPUX9K2 1977

and then:

#define CONFIG_MACH_TYPE MACH_TYPE_EB_CPUX9K2


-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH V3] Arm: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
  2011-10-31  7:26 [U-Boot] [PATCH V2] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board Jens Scharsig
  2011-10-31  7:46 ` Igor Grinberg
@ 2011-10-31 18:52 ` Jens Scharsig
  2011-11-01 11:44   ` Igor Grinberg
  2011-11-05 12:44   ` Albert ARIBAUD
  1 sibling, 2 replies; 8+ messages in thread
From: Jens Scharsig @ 2011-10-31 18:52 UTC (permalink / raw)
  To: u-boot


* re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board

Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
---
 include/configs/eb_cpux9k2.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/configs/eb_cpux9k2.h b/include/configs/eb_cpux9k2.h
index 4324172..b08de4a 100644
--- a/include/configs/eb_cpux9k2.h
+++ b/include/configs/eb_cpux9k2.h
@@ -41,6 +41,8 @@
 #define CONFIG_MISC_INIT_R
 #define CONFIG_BOARD_EARLY_INIT_F
 
+#define MACH_TYPE_EB_CPUX9K2		1977
+#define CONFIG_MACH_TYPE		MACH_TYPE_EB_CPUX9K2
 /*--------------------------------------------------------------------------*/
 #define CONFIG_SYS_TEXT_BASE 		0x00000000
 #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
-- 
1.7.3.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH V3] Arm: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
  2011-10-31 18:52 ` [U-Boot] [PATCH V3] Arm: " Jens Scharsig
@ 2011-11-01 11:44   ` Igor Grinberg
  2011-11-05 12:44   ` Albert ARIBAUD
  1 sibling, 0 replies; 8+ messages in thread
From: Igor Grinberg @ 2011-11-01 11:44 UTC (permalink / raw)
  To: u-boot

On 10/31/11 20:52, Jens Scharsig wrote:
> 
> * re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
> 
> Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>

Acked-by: Igor Grinberg <grinberg@compulab.co.il>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH V2] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
  2011-10-31  8:48     ` Igor Grinberg
@ 2011-11-05 10:52       ` Albert ARIBAUD
  0 siblings, 0 replies; 8+ messages in thread
From: Albert ARIBAUD @ 2011-11-05 10:52 UTC (permalink / raw)
  To: u-boot

Le 31/10/2011 09:48, Igor Grinberg a ?crit :
> Hi Jens,
>
> On 10/31/11 10:27, Jens Scharsig wrote:
>> Am 2011-10-31 08:46, schrieb Igor Grinberg:
>>> Hi Jens,
>>>> @@ -41,6 +41,8 @@
>>>>   #define CONFIG_MISC_INIT_R
>>>>   #define CONFIG_BOARD_EARLY_INIT_F
>>>>
>>>> +#define MACH_TYPE_EB_CPUX9K2           1977
>>>> +
>>>
>>> While you are at it, probably, it will be a good time
>>> to switch to the new standard and use the CONFIG_MACH_TYPE
>>> option. Please, read the README file.
>>>
>>>>   /*--------------------------------------------------------------------------*/
>>>>   #define CONFIG_SYS_TEXT_BASE 		0x00000000
>>>>   #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
>>>
>>
>> Dear Albert ARIBAUD,
>>
>> What's your opinion?
>>
>> #define MACH_TYPE_EB_CPUX9K2 1977
>>
>> or
>>
>> #define CONFIG_MACH_TYPE 1977
>
> It should be both:
>
> #define MACH_TYPE_EB_CPUX9K2 1977
>
> and then:
>
> #define CONFIG_MACH_TYPE MACH_TYPE_EB_CPUX9K2

Correct.

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH V3] Arm: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
  2011-10-31 18:52 ` [U-Boot] [PATCH V3] Arm: " Jens Scharsig
  2011-11-01 11:44   ` Igor Grinberg
@ 2011-11-05 12:44   ` Albert ARIBAUD
  1 sibling, 0 replies; 8+ messages in thread
From: Albert ARIBAUD @ 2011-11-05 12:44 UTC (permalink / raw)
  To: u-boot

Hi Jens,

Le 31/10/2011 19:52, Jens Scharsig a ?crit :
> * re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board
>
> Signed-off-by: Jens Scharsig<js_at_ng@scharsoft.de>
> ---
>   include/configs/eb_cpux9k2.h |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/configs/eb_cpux9k2.h b/include/configs/eb_cpux9k2.h
> index 4324172..b08de4a 100644
> --- a/include/configs/eb_cpux9k2.h
> +++ b/include/configs/eb_cpux9k2.h
> @@ -41,6 +41,8 @@
>   #define CONFIG_MISC_INIT_R
>   #define CONFIG_BOARD_EARLY_INIT_F
>
> +#define MACH_TYPE_EB_CPUX9K2		1977
> +#define CONFIG_MACH_TYPE		MACH_TYPE_EB_CPUX9K2
>   /*--------------------------------------------------------------------------*/
>   #define CONFIG_SYS_TEXT_BASE 		0x00000000
>   #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */

Applied to u-boot-arm/master, thanks!

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-11-05 12:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-31  7:26 [U-Boot] [PATCH V2] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board Jens Scharsig
2011-10-31  7:46 ` Igor Grinberg
2011-10-31  8:27   ` Jens Scharsig
2011-10-31  8:48     ` Igor Grinberg
2011-11-05 10:52       ` Albert ARIBAUD
2011-10-31 18:52 ` [U-Boot] [PATCH V3] Arm: " Jens Scharsig
2011-11-01 11:44   ` Igor Grinberg
2011-11-05 12:44   ` Albert ARIBAUD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox