From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Tue, 1 Nov 2011 10:39:35 -0500 Subject: [U-Boot] [PATCH v5 05/11] arm, davinci: add support for new spl framework In-Reply-To: <4EAF7E57.2000104@denx.de> References: <1320036790-24283-1-git-send-email-hs@denx.de> <1320036790-24283-6-git-send-email-hs@denx.de> <4EAF1CA7.5010403@freescale.com> <4EAF7E57.2000104@denx.de> Message-ID: <4EB012B7.5040600@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/01/2011 12:06 AM, Heiko Schocher wrote: > Hello Scott, > > Scott Wood wrote: >> On 10/30/2011 11:53 PM, Heiko Schocher wrote: >> This is common to most NAND SPLs. It would be nice to stick this in a >> common place (at least the loading part, maybe not the jump). Not >> nand_spl_simple.c, as it's utility is not limited to the simple driver. >> Maybe drivers/mtd/nand/nand_spl_load.c? > > moved to drivers/mtd/nand/spl_nand_load.c, also I want to let the jump > in this file. I prefer the name "spl_nand_load.c as we have already a > > CONFIG_SPL_NAND_SIMPLE -> CONFIG_SPL_NAND_LOAD -> spl_nand_load.c > > Is this OK for you? > > Shouldn;t we rename nand_spl_simple.c to spl_nand_simple.c also? I suggested nand_spl_load.c because we already have a nand_spl_simple.c. :-) I don't really care which way it goes, as long as it's consistent. -Scott