From: Simon Schwarz <simonschwarzcor@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] nand_spl_simple: Add omap3 DMA usage to SPL
Date: Wed, 02 Nov 2011 10:57:17 +0100 [thread overview]
Message-ID: <4EB113FD.7000005@gmail.com> (raw)
In-Reply-To: <4EAF11A7.6020304@freescale.com>
Hi Scott
On 10/31/2011 10:22 PM, Scott Wood wrote:
> What would the semantics of a generic dma_wait_for_transfer() be?
>
> I just don't see how this is generic at all, whatever the name.
>
Hm. It would be a check if the given DMA channel is active - and if it
is busy waiting for it.
So, what would then be a generic interface for DMA? I see that this is a
verrry basic solution - but where do you see the actual problems
implementing this interface for other DMA controllers? Or do you think
that the interface is to simple?
>> A whole new driver is IMHO not the right thing as there is too much
>> duplicated code then.
>
> So factor the common bits out into a separate file.
>
I haven't given up on the general solution yet. If I don't see another
way I will do that.
Regards
Simon
next prev parent reply other threads:[~2011-11-02 9:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 10:10 [U-Boot] [PATCH 0/2] Use DMA in SPL Simon Schwarz
2011-10-16 10:10 ` [U-Boot] [PATCH 1/2] nand_spl_simple: Add omap3 DMA usage to SPL Simon Schwarz
2011-10-23 18:40 ` Wolfgang Denk
2011-10-25 18:24 ` Scott Wood
2011-10-31 8:56 ` Simon Schwarz
2011-10-31 21:22 ` Scott Wood
2011-11-02 9:57 ` Simon Schwarz [this message]
2011-11-02 17:29 ` Scott Wood
2011-10-16 10:10 ` [U-Boot] [PATCH 2/2] devkit8000: Activate DMA support in SPL Simon Schwarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB113FD.7000005@gmail.com \
--to=simonschwarzcor@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox