From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Schwarz Date: Wed, 02 Nov 2011 10:57:17 +0100 Subject: [U-Boot] [PATCH 1/2] nand_spl_simple: Add omap3 DMA usage to SPL In-Reply-To: <4EAF11A7.6020304@freescale.com> References: <1318759804-18688-1-git-send-email-simonschwarzcor@gmail.com> <1318759804-18688-2-git-send-email-simonschwarzcor@gmail.com> <4EA6FEF9.6070208@freescale.com> <4EAE62D6.5030109@gmail.com> <4EAF11A7.6020304@freescale.com> Message-ID: <4EB113FD.7000005@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Scott On 10/31/2011 10:22 PM, Scott Wood wrote: > What would the semantics of a generic dma_wait_for_transfer() be? > > I just don't see how this is generic at all, whatever the name. > Hm. It would be a check if the given DMA channel is active - and if it is busy waiting for it. So, what would then be a generic interface for DMA? I see that this is a verrry basic solution - but where do you see the actual problems implementing this interface for other DMA controllers? Or do you think that the interface is to simple? >> A whole new driver is IMHO not the right thing as there is too much >> duplicated code then. > > So factor the common bits out into a separate file. > I haven't given up on the general solution yet. If I don't see another way I will do that. Regards Simon