[U-Boot] [PATCH v2] sandbox: Change md command to use map_physmem

[U-Boot] [PATCH v2] sandbox: Change md command to use map_physmem

[Simon Glass]

Sandbox wants to support commands which use memory. The map_physmen()
call provides this feature, so should be used more consistently in
U-Boot.

Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v2:
- Remove check for NULL pointer since map_physmem apparently cannot fail

 common/cmd_mem.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/common/cmd_mem.c b/common/cmd_mem.c
index 28476d7..461ee19 100644
--- a/common/cmd_mem.c
+++ b/common/cmd_mem.c
@@ -33,6 +33,7 @@
 #include <dataflash.h>
 #endif
 #include <watchdog.h>
+#include <asm/io.h>
 
 #ifdef	CMD_MEM_DEBUG
 #define	PRINTF(fmt,args...)	printf (fmt ,##args)
@@ -141,9 +142,13 @@ int do_mem_md ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 # endif
 
 	{
+		ulong bytes = size * length;
+		void *buf = map_physmem(addr, bytes, MAP_WRBACK);
+
 		/* Print the lines. */
-		print_buffer(addr, (void*)addr, size, length, DISP_LINE_LEN/size);
-		addr += size*length;
+		print_buffer(addr, buf, size, length, DISP_LINE_LEN / size);
+		addr += bytes;
+		unmap_physmem(buf, bytes);
 	}
 #endif
 
-- 
1.7.3.1

[U-Boot] [PATCH v2] sandbox: Change md command to use map_physmem

[Mike Frysinger]

Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike

[U-Boot] [PATCH v2] sandbox: Change md command to use map_physmem

[Matthias Weisser]

Am 26.10.2011 01:51, schrieb Simon Glass:
> Sandbox wants to support commands which use memory. The map_physmen()
> call provides this feature, so should be used more consistently in
> U-Boot.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

After fixing malloc problem:

Tested-by: Matthias Weisser <weisserm@arcor.de>

Regards Matthias

[U-Boot] [PATCH v2] sandbox: Change md command to use map_physmem

[Simon Glass]

Hi Matthias,

On Wed, Nov 2, 2011 at 11:39 AM, Matthias Weisser <weisserm@arcor.de> wrote:
> Am 26.10.2011 01:51, schrieb Simon Glass:
>> Sandbox wants to support commands which use memory. The map_physmen()
>> call provides this feature, so should be used more consistently in
>> U-Boot.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>
> After fixing malloc problem:
>
> Tested-by: Matthias Weisser <weisserm@arcor.de>
>

Thanks - I tracked this down to 2d01dd9 which puts dlmalloc.o in the
Makefile twice. It is fixed by your 'sandbox: Add improved RAM
simulation' so I will not submit a patch.

Regards,
Simon

> Regards Matthias
>

[U-Boot] [PATCH v2] sandbox: Change md command to use map_physmem

[Wolfgang Denk]

Dear Simon Glass,

In message <1319586669-22190-1-git-send-email-sjg@chromium.org> you wrote:
> Sandbox wants to support commands which use memory. The map_physmen()
> call provides this feature, so should be used more consistently in
> U-Boot.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v2:
> - Remove check for NULL pointer since map_physmem apparently cannot fail
> 
>  common/cmd_mem.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unix: Some say the learning curve is steep,  but  you  only  have  to
climb it once.                                      - Karl Lehenbauer